pybind/mgr/pg_autoscaler: Add warning message if pool fail to scale to recommended PG_NUM #57467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o recommended PG_NUM The pg_autoscaler fails to scale the pool if the recommended PG_NUM value varies from the current value by more than the scaling threshold. There is no way to get to know why pg_autoscaler is failing to scale the pool. Log a warning message in mgr if pg_autoscaler is failing to implement recommended PG_NUM. Fixes: https://tracker.ceph.com/issues/66015 Signed-off-by: Prashant D <pdhange@redhat.com>
|
jenkins test api |
On second thought, I thought this would cause a cluster warning, but I took a closer look, and it seems like it's just a log message. |
ljflores
approved these changes
May 20, 2024
| adjust = True | ||
| else: | ||
| if final_pg_target != p['pg_num_target']: | ||
| self.log.warning("pool %s won't scale due to recommended PG_NUM target" |
There was a problem hiding this comment.
Suggested change
| self.log.warning("pool %s won't scale due to recommended PG_NUM target" | |
| self.log.warning("pool %s won't scale because recommended PG_NUM target" |
Comment on lines
+621
to
+623
| self.log.warning("Please adjust threshold to lower multiple to scale" | ||
| " pool %s", | ||
| pool_name) |
There was a problem hiding this comment.
Suggested change
| self.log.warning("Please adjust threshold to lower multiple to scale" | |
| " pool %s", | |
| pool_name) | |
| self.log.warning("To scale pool %s, please adjust threshold to a lower multiple", | |
| pool_name) |
kamoltat
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg_autoscaler fails to scale the pool if the recommended PG_NUM value varies from the current value by more than the scaling threshold. There is no way to get to know why pg_autoscaler is failing to scale the pool.
Log a warning message in mgr if pg_autoscaler is failing to implement recommended PG_NUM.
Fixes: https://tracker.ceph.com/issues/66015
Signed-off-by: Prashant D pdhange@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e