Uplift to fix all vulnerabilities

[jasonkshar]

Addressed all vulnerabilities as reported by npm audit. Many major changes were made as part of this:

• Uplifted Terra-Toolkit from 1.X to 5.X
  • v5 of Terra-Toolkit removed support for Nightwatch, so those tests are rewritten in WDIO
• Updated to babel 7.x
• Updated to webpack 4.x

[jasonkshar]

There is one outstanding peer dependency warning:
npm WARN terra-toolkit@5.12.0 requires a peer of webpack@^4.30.0 but none is installed. You must install peer dependencies yourself.

I don't think you can update webpack to 4.30.0 because of this issue: webpack/webpack#8656

[jasonkshar]

Since the wdio tests require docker now, I'm wondering if there's something that needs to be configured for travis. Might have to reach out to the terra-toolkit maintainers for that.

[kolkheang]

Maybe we need to install Chrome using headless mode?

https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-the-chrome-addon-in-the-headless-mode

[jasonkshar]

No bueno. That testing should all be contained within the docker container, I think.

[jasonkshar]

guess you needed to specify a few things:

• node 10
• docker-compose and Dockerfile

[kolkheang]

@jasonkshar could you squash all the commits when you merge?

@vibhutitripathi12 , @shriniketsarkar could you review when you get a chance?

[kolkheang]

Are all of these @babel/plugin-proposal-* modules needed?

[jasonkshar]

I think so. I used https://github.com/babel/babel-upgrade to go through it.

[kolkheang]

+1

[jasonkshar]

I don't have permissions to merge, but isn't there an option to squash and merge when accepting this PR?

[kolkheang]

@jasonkshar can you re-run npm run build? It looks like a few files were deleted from the /build/ dir.

[jasonkshar]

If you're referring to the intl-polyfill-bundle.min.js file, that file gets removed when I npm run build is executed.

[kolkheang]

@jasonkshar I think that is going to be a problem for the app since currently that file is being referenced in the index.html.
https://github.com/cerner/ascvd-risk-calculator/blob/master/index.html#L11

[jasonkshar]

That was a problem then, couldn't trust webpack-merge

[shriniketsarkar]

@jasonkshar Sorry about the delay in reviewing it. Thanks for working on this :) .

[kolkheang]

Thanks @jasonkshar for contributing!