Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Temp lock down eslint-plugin-react #19

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Temp lock down eslint-plugin-react #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00636e1
Temp lock down eslint-plugin-react
emilyrohrbough Dec 31, 2018
c0c3841
Update CHANGELOG.md
emilyrohrbough Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Unreleased

### Changed
* Added after as globals for test files recursively under a "wdio" directory
* Tempararily lock-down `eslint-plugin-react`. V7.12.0 was released with bugs and has not yet been fixed. Locking this down until a fix is released.

2.1.0 - (August 29, 2018)
------------------
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"eslint-plugin-compat": "^2.5.1",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.1",
"eslint-plugin-react": "^7.11.0"
"eslint-plugin-react": "7.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.12.1 was released last night, are the issues fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure 😄 I found this bug a few days ago. I will check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 tested out the newest release and there are still issues with the reportUndeclaredPropTypes rule. Logged an issue to eslint-plugin-react: jsx-eslint/eslint-plugin-react#2108.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work looking into this!

},
"peerDependencies": {
"eslint": "^5.0.0"
Expand Down