This repository has been archived by the owner on May 19, 2020. It is now read-only.
Unlock 'eslint-plugin-react' Version #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amichaelparker
requested review from
bjankord,
JakeLaCombe,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
emilyrohrbough
approved these changes
Jan 9, 2019
bjankord
approved these changes
Jan 9, 2019
StephenEsser
reviewed
Jan 9, 2019
| @@ -24,6 +24,9 @@ module.exports = { | |||
| // This config updates the rule to require one or the other. | |||
| 'jsx-a11y/label-has-associated-control': [2, { assert: 'either' }], | |||
| 'react/destructuring-assignment': 'off', | |||
| // This updates the rule below to throw a warning rather than an error | |||
| // when using eslint-plugin-react 7.12.2 or above. | |||
| 'react/jsx-wrap-multilines': 'warn', | |||
There was a problem hiding this comment.
Will this rule be turned on in the future in the next major version bump?
There was a problem hiding this comment.
yes it should. it breaks current lint tests. We should get an issue logged to remove this rule
StephenEsser
approved these changes
Jan 9, 2019
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unlocks the version of 'eslint-plugin-react' in package.json.
Closes #21