This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-popup] Enabled close button in Popup #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2024 18:36
saket2403
reviewed
May 17, 2024
| }; | ||
|
|
||
| const defaultProps = { | ||
| classNameInner: null, | ||
| contentHeightMax: -1, | ||
| contentWidthMax: -1, | ||
| isFocusedDisabled: false, | ||
| isHeaderDisabled: false, | ||
| isHeaderDisabled: true, |
There was a problem hiding this comment.
Default value should be false only. Since prop name is isHeaderDisabled it should remove the header when true but as per your implementation it will add header when true
There was a problem hiding this comment.
Changed it to false
saket2403
reviewed
May 17, 2024
| }; | ||
|
|
||
| const defaultProps = { | ||
| isPopupHeaderDisabled: true, |
There was a problem hiding this comment.
Header is getting added when isPopupHeaderDisabled is true it should be the other way. Header should be added when prop is false.
There was a problem hiding this comment.
Removed this prop since Popup by default provides the header with close button
added 2 commits
May 17, 2024 15:34
adavijit
changed the title
saket2403
approved these changes
May 20, 2024
sugan2416
approved these changes
May 20, 2024
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Why it was changed:
Should be able to focus close button to close the popup
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10398
Thank you for contributing to Terra.
@cerner/terra