Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-date-time-picker] Focus fix for mobile view #2165

Closed
wants to merge 8 commits into from

Conversation

adavijit
Copy link
Collaborator

@adavijit adavijit commented May 16, 2024

Summary

What was changed:

  • Focused the button to open calendar after calendar is closed.
  • Introduced a new prop disableButtonFocusOnClose to optionally disable focusing the button when the calendar is closed.
  • Updated jest and wdio screenshots

Why it was changed:
The onBlur event is not triggered in mobile view for date time picker because the focus is lost after the calendar is closed.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10400


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2165 May 16, 2024 13:36 Destroyed
@adavijit adavijit changed the title UXPLATFORM-10400 DatePicker focus fixed for mobile view [terra-date-time-picker] Focus fix for mobile view May 16, 2024
@adavijit adavijit self-assigned this May 19, 2024
@adavijit
Copy link
Collaborator Author

The changes are done along with #2167

@adavijit adavijit closed this May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant