promote StableCertificateRequestName and SecretsFilteredCaching to Be…

…ta & change DontAllowInsecureCSRUsageDefinition from GA to Beta before release Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager · Aug 25, 2023 · 3ce55f8 · 3ce55f8
1 parent f158e1d
commit 3ce55f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/internal/controller/feature/features.go b/internal/controller/feature/features.go
@@ -82,6 +82,7 @@ const (
 
 	// Owner: N/A
 	// Alpha: v1.10
+	// Beta: v1.13
 	//
 	// StableCertificateRequestName will enable generation of CertificateRequest resources with a fixed name. The name of the CertificateRequest will be a function of Certificate resource name and its revision
 	// This feature gate will disable auto-generated CertificateRequest name
@@ -98,6 +99,7 @@ const (
 
 	// Owner: @irbekrm
 	// Alpha v1.12
+	// Beta: v1.13
 	//
 	// SecretsFilteredCaching reduces controller's memory consumption by
 	// filtering which Secrets are cached in full using
@@ -109,7 +111,7 @@ const (
 	SecretsFilteredCaching featuregate.Feature = "SecretsFilteredCaching"
 
 	// Owner: @inteon
-	// GA: v1.13
+	// Beta: v1.13
 	//
 	// DontAllowInsecureCSRUsageDefinition will prevent the webhook from allowing
 	// CertificateRequest's usages to be only defined in the CSR, while leaving
@@ -125,15 +127,15 @@ func init() {
 // To add a new feature, define a key for it above and add it here. The features will be
 // available on the cert-manager controller binary.
 var defaultCertManagerFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
-	DontAllowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.GA},
+	DontAllowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.Beta},
+	StableCertificateRequestName:        {Default: true, PreRelease: featuregate.Beta},
+	SecretsFilteredCaching:              {Default: true, PreRelease: featuregate.Beta},
 
 	ValidateCAA: {Default: false, PreRelease: featuregate.Alpha},
 	ExperimentalCertificateSigningRequestControllers: {Default: false, PreRelease: featuregate.Alpha},
 	ExperimentalGatewayAPISupport:                    {Default: false, PreRelease: featuregate.Alpha},
 	AdditionalCertificateOutputFormats:               {Default: false, PreRelease: featuregate.Alpha},
 	ServerSideApply:                                  {Default: false, PreRelease: featuregate.Alpha},
 	LiteralCertificateSubject:                        {Default: false, PreRelease: featuregate.Alpha},
-	StableCertificateRequestName:                     {Default: false, PreRelease: featuregate.Alpha},
 	UseCertificateRequestBasicConstraints:            {Default: false, PreRelease: featuregate.Alpha},
-	SecretsFilteredCaching:                           {Default: false, PreRelease: featuregate.Alpha},
 }
diff --git a/internal/webhook/feature/features.go b/internal/webhook/feature/features.go
@@ -54,7 +54,7 @@ const (
 	LiteralCertificateSubject featuregate.Feature = "LiteralCertificateSubject"
 
 	// Owner: @inteon
-	// GA: v1.13
+	// Beta: v1.13
 	//
 	// DontAllowInsecureCSRUsageDefinition will prevent the webhook from allowing
 	// CertificateRequest's usages to be only defined in the CSR, while leaving
@@ -74,7 +74,7 @@ func init() {
 //
 // Where utilfeature is github.com/cert-manager/cert-manager/pkg/util/feature.
 var webhookFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
-	DontAllowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.GA},
+	DontAllowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.Beta},
 
 	AdditionalCertificateOutputFormats: {Default: false, PreRelease: featuregate.Alpha},
 	LiteralCertificateSubject:          {Default: false, PreRelease: featuregate.Alpha},