Merge pull request #5879 from maelvls/structured-logs-deprecate

Deprecate klog flags and add a deprecation message
cert-manager · Aug 25, 2023 · 9ebc08c · 9ebc08c
2 parents 1bc7182 + 1c85525
commit 9ebc08c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/logs/logs.go b/pkg/logs/logs.go
@@ -89,7 +89,9 @@ func AddFlags(opts *logsapi.LoggingConfiguration, fs *pflag.FlagSet) {
 		switch f.Name {
 		case "add_dir_header", "alsologtostderr", "log_backtrace_at", "log_dir", "log_file", "log_file_max_size",
 			"logtostderr", "one_output", "skip_headers", "skip_log_headers", "stderrthreshold":
-			fs.AddGoFlag(f)
+			pf := pflag.PFlagFromGoFlag(f)
+			pf.Deprecated = "this flag may be removed in the future"
+			fs.AddFlag(pf)
 		}
 	})