Skip to content

Commit

Permalink
Merge pull request #6135 from cloud-native-team/master
Browse files Browse the repository at this point in the history
fix function name in comments
  • Loading branch information
jetstack-bot committed Jun 7, 2023
2 parents f8940ab + 4723347 commit c035090
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func (c *certificateRequestApproval) cacheAPIResource(groupKind schema.GroupKind

var errNoResourceExists = fmt.Errorf("no resource registered")

// signerNameForAPIResource returns the computed signerName for a given API resource
// signerNamesForAPIResource returns the computed signerName for a given API resource
// referenced by a CertificateRequest in a namespace.
func signerNamesForAPIResource(name, namespace string, info resourceInfo) []string {
signerNames := make([]string, 0, 2)
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/cainjector/indexers.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func certFromSecretToInjectableMapFuncBuilder(cl client.Reader, log logr.Logger,
}
}

// certFromSecretToInjectableMapFuncBuilder returns a handler.MapFunc that, for
// certToInjectableMapFuncBuilder returns a handler.MapFunc that, for
// a Certificate change, ensures that if this Certificate that is configured as
// a CA source for an injectable via inject-ca-from annotation, a reconcile loop
// will be triggered for this injectable
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func (b *BlockingEventHandler) OnDelete(obj interface{}) {
b.WorkFunc(obj)
}

// BuildAnnotationsCopy takes a map of annotations and a list of prefix
// BuildAnnotationsToCopy takes a map of annotations and a list of prefix
// filters and builds a filtered map of annotations. It is used to filter
// annotations to be copied from Certificate to CertificateRequest and from
// CertificateSigningRequest to Order.
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/pki/certificatetemplate.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func CertificateTemplateFromCertificateRequest(cr *v1.CertificateRequest) (*x509
)
}

// CertificateTemplateFromCertificateRequest will create a x509.Certificate for the given
// CertificateTemplateFromCertificateSigningRequest will create a x509.Certificate for the given
// CertificateSigningRequest resource
func CertificateTemplateFromCertificateSigningRequest(csr *certificatesv1.CertificateSigningRequest) (*x509.Certificate, error) {
duration, err := DurationFromCertificateSigningRequest(csr)
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/predicate/certificate.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func CertificateSecretName(name string) Func {
}
}

// CertificateSecretName returns a predicate that used to filter Certificates
// CertificateNextPrivateKeySecretName returns a predicate that used to filter Certificates
// to only those with the given 'status.nextPrivateKeySecretName'.
// It is not possible to select Certificates with a 'nil' secret name using
// this predicate function.
Expand Down

0 comments on commit c035090

Please sign in to comment.