[BUGFIX] defaulting partial ControllerConfiguration logging options

[inteon]

The current defaulting logic for the ControllerConfiguration logging options fails in case a partial logging configuration is provided.
(it only defaults the logging options in case no logging options are provided, and does not default any of the logging option fields in case a partial configuration is provided)

Introduced in #5337, this has not been released yet.

This is how you can test the logging options:

$ cat config.yaml 
apiVersion: controller.config.cert-manager.io/v1alpha1
kind: ControllerConfiguration
logging:
  format: json
$ _bin/server/controller-linux-amd64 --config config.yaml 
{"ts":1692259054053.9272,"caller":"clientcmd/client_config.go:618","msg":"Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.\n","v":0}
{"ts":1692259054053.972,"caller":"clientcmd/client_config.go:623","msg":"error creating inClusterConfig, falling back to default config: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined\n","v":0}
{"ts":1692259054054.059,"caller":"app/start.go:152","msg":"cert-manager: Failed to run the controller","err":"error creating rest config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"}

Kind

/kind bug

Release Note

NONE

[wallrj]

I think I spotted a typo. Otherwise looks good to me.

It looks like you found an existing logging API struct which is now embedded into our configuration.
Have I understood correctly?
Is that same struct also embedded in the webhook configuration?

[inteon]

Is that same struct also embedded in the webhook configuration?

Not yet, I want to do that in this PR: #6243

[wallrj]

Thanks Tim.

/lgtm

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon,wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment