Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Webhook to controller-runtime. #6455

Merged
merged 2 commits into from Feb 12, 2024
Merged

Switch Webhook to controller-runtime. #6455

merged 2 commits into from Feb 12, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Oct 29, 2023 •
edited

Migrates the webhook to use c/r.

Kind

/kind cleanup

Release Note

NONE

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/testing Issues relating to testing labels Oct 29, 2023
@inteon inteon force-pushed the webhook_cr branch 8 times, most recently from fe5f41b to 42d43df Compare November 2, 2023 12:33
@inteon
Copy link
Member Author

inteon commented Nov 2, 2023

/test pull-cert-manager-master-make-test

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2023
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2024
@inteon inteon force-pushed the webhook_cr branch 2 times, most recently from b65a3a0 to af6b6d8 Compare January 7, 2024 12:35
@inteon inteon added this to the 1.14 milestone Jan 7, 2024
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
@inteon inteon modified the milestones: 1.14, 1.15 Jan 11, 2024
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2024
@jetstack-bot jetstack-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 27, 2024
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@inteon inteon force-pushed the webhook_cr branch 2 times, most recently from b606459 to 72116b8 Compare January 29, 2024 14:07
@inteon inteon mentioned this pull request Feb 2, 2024
Merged
@inteon inteon changed the title Simplify webhook and switch Webhook to controller-runtime. Switch Webhook to controller-runtime. Feb 5, 2024
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2024
@inteon inteon mentioned this pull request Feb 10, 2024
Merged
inteon
inteon commented Feb 12, 2024
View reviewed changes
pkg/server/tls/source.go
// error if an irrecoverable error occurs whilst running.
Run(context.Context) error
Start(context.Context) error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed Run to Start to match the c/r Runnable interface: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/manager#Runnable

@inteon
Simplify webhook and switch Webhook to controller-runtime.
b9a216c 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
buildAdmissionChain: return admission.PluginChain instead of admissio…
8eaeeb7 
…n.Interface

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@inteon
Copy link
Member Author

inteon commented Feb 12, 2024

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@jetstack-bot jetstack-bot merged commit b632eed into cert-manager:master Feb 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatsMrTalbot ThatsMrTalbot ThatsMrTalbot left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @ThatsMrTalbot @jetstack-bot