New option to specify encryption and MAC algorithms for PKCS#12 keystores. #6548

snorwin · 2023-12-12T14:42:04Z

Pull Request Motivation

This PR adds a new field .spec.keystores.pkcs12.algorithm to allow specifying encryption and MAC algorithms for PKCS#12 keystores, enhancing compatibility with OpenSSL 3 and keep maintaining support for legacy systems.

Kind

/kind feature

Release Note

New option .spec.keystores.pkcs12.algorithms to specify encryption and MAC algorithms for PKCS#12 keystores. Fixes issues #5957 and #6523.

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

jetstack-bot · 2023-12-12T14:42:14Z

Hi @snorwin. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

inteon · 2023-12-12T16:00:34Z

/ok-to-test

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

snorwin · 2023-12-12T17:41:44Z

@inteon thanks for checking this PR. Unfortunately I forget to commit some fixes, could you approve the tests again?

inteon · 2023-12-12T17:42:45Z

/ok-to-test

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

snorwin · 2023-12-12T18:49:30Z

/retest

internal/apis/certmanager/v1alpha2/types_certificate.go

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

internal/apis/certmanager/v1alpha2/types_certificate.go

snorwin · 2023-12-13T12:48:11Z

/test pull-cert-manager-master-e2e-v1-28

SgtCoDFish

I was asked to take a look at this and we discussed it this morning in the open cert-manager standup. Unfortunately I don't have many working days left in the year so I might not be able to help much beyond this, but I think there's something interesting here.

The gist of my other comments is: If we expose algorithm names like AES256 in our API via AESPKCS12Algorithm I worry we might introduce a few problems for users.

I don't really see how we can avoid having to create an abstraction for this ourselves. That is, in our CRD we give people the option between Modern2023, LegacyDES and LegacyRC2, and today those would map to Modern2023, LegacyDES and LegacyRC2 in the library - but we'd be able to map them to different encoders down the road if the pkcs12 library encoders changed.

To allow us to maintain backwards compatibility in the future, we could add a test which checks that the profiles in the pkcs12 Library haven't changed. That test would start failing if we bump software.sslmate.com/src/go-pkcs12 and one of the encoders changes.

The tricky part is that the parameters we need are private: Encoder.macAlgorithm, Encoder.certAlgorithm, Encoder.keyAlgorithm - and so there's no way for us to create an Encoder with different parameters... but we could fork the project or make upstream changes if needed down the road. Since these are unlikely to change, I think it's fine for that to be a problem we leave to solve another day.

What do you think?

pkg/controller/certificates/issuing/internal/keystore.go

SgtCoDFish · 2023-12-14T12:42:09Z

Oh, and an important thing I forgot in my last comment: thank you for rasiing this ❤️ Awesome to see contributions like this!

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

SgtCoDFish

/lgtm
/approve
/hold

I think this looks great and I think it's an improvement as written. I'd like this to be in cert-manager 1.14!

I'm adding a hold to give others the chance to review, as I'm leaving for the holidays soon and won't be able to follow up until 2024. Thanks for this @snorwin !

inteon

This an awesome contribution!
LGTM.
/lgtm
/approve

jetstack-bot · 2023-12-20T10:10:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SgtCoDFish,inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

inteon · 2023-12-20T10:28:36Z

internal/apis/certmanager/types_certificate.go

+	// `Modern2023`: Secure algorithm. Use this option in case you have to always use secure algorithms
+	// (eg. because of company policy). Please note that the security of the algorithm is not that important
+	// in reality, because the unencrypted certificate and private key are also stored in the Secret.
+	Algorithms PKCS12Algorithms


Suggested change

Algorithms PKCS12Algorithms

Algorithm PKCS12Algorithm

Would it make sense to rename this field to Algorithm instead of Algorithms?

As it covers a collection of algorithms, i.e. key, certificate encryption algorithm and MAC algorithm. I thought it might be more accurate to use the plural.

@SgtCoDFish WDYT?

I have no strong preference. I think both work! I have a soft preference for Algorithm just because most users won't know or appreciate that there are mulitple algorithms being changed by this so it feels a little more natural to use a singular here although I agree that the plural might be more correct.

We could maybe use something like Profile since we're not allowing users to change the underlying algos, but rather to pick one of the profiles we specify. I really don't think it matters much though!

@snorwin feel free to unhold if you think the name is ok as-is.

I'll rename the field to Profile, that should make it ready to be merged.

inteon · 2023-12-20T10:30:15Z

I reworded the comments that explain the algorithms in the API 24794fe.
Also, I added a small comment, PTAL once you are back @SgtCoDFish: #6548 (comment)

inteon · 2024-01-02T10:23:07Z

@erikgb do we have this in trust-manager already? Would it make sense to add this option there too?

erikgb · 2024-01-02T10:30:47Z

@erikgb do we have this in trust-manager already? Would it make sense to add this option there too?

@inteon No, not yet. It would make a lot of sense to add it. Since trust-manager is not yet GA, we might consider making LegacyDES the default there.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

inteon · 2024-01-03T12:48:40Z

/unhold
/lgtm
As suggested by @SgtCoDFish, I renamed the option from Algorithms to Profile

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://github.com/cert-manager/cert-manager) | minor | `v1.13.3` -> `v1.14.1` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.14.1`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.1) [Compare Source](cert-manager/cert-manager@v1.14.0...v1.14.1) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. > 📢 cert-manager `v1.14.1` fixes bugs found *during* the release of `v1.14.0`. > > When upgrading to cert-manager release 1.14, please skip `v1.14.0` and install this patch version instead. ##### Documentation - [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) - [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) - [Installation instructions](https://cert-manager.io/docs/installation/) ##### Changes since `v1.14.0` ##### Bug or Regression - Fix broken cainjector image value in Helm chart ([#6693](cert-manager/cert-manager#6693), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Fix bug in cmctl namespace detection which prevented it being used as a startupapicheck image in namespaces other than cert-manager. ([#6706](cert-manager/cert-manager#6706), [@inteon](https://github.com/inteon)) - Fix bug in cmctl which caused `cmctl experimental install` to panic. ([#6706](cert-manager/cert-manager#6706), [@inteon](https://github.com/inteon)) ### [`v1.14.0`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.0) [Compare Source](cert-manager/cert-manager@v1.13.3...v1.14.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. > ⚠️ This version has known issues. Please install `v1.14.1` instead. > > During the release of `v1.14.0`, the Helm chart was found to use the wrong OCI image for the `cainjector` Deployment, > which caused the Helm installation and the static manifest based installation to fail. > Upon discovery of this bug, the release of `v1.14.0` was paused before the Helm chart or GitHub release were published; > but the Git tag and the OCI images had already been published. > > The cert-manager team next fixed the Helm chart and two other bugs which are listed in the "Known Issues" section below, > and then released `v1.14.1`, which is the version that users are strongly advised to install when they upgrade to 1.14. > > In order to complete the stalled `v1.14.0` release, > the Helm chart and static YAML installation files were regenerated on a team member's laptop, > using exactly the same build scripts as are used in the automated release process, > and using the `v1.14.1` version of the code. > The working `v1.14.0` Helm chart was published, > and the working versions of the static manifest files attached to the draft `v1.14.0` GitHub release, > and that was then published. > > For these reasons, users are strongly advised to skip this version and install the `v1.14.1` Helm chart instead. ##### Known Issues - During the release of `v1.14.0`, the Helm chart for this version was found to use the wrong OCI image for the `cainjector` Deployment, which caused the Helm installation to fail. In order to complete the release, the cert-manager team have manually updated the Helm chart for this version, which contains all the Helm chart fixes which are in `v1.14.1`. But users are strongly advised to skip this version and install the `v1.14.1` Helm chart instead. - A bug in cmctl namespace detection prevents it being used as a `startupapicheck` image in namespaces other than cert-manager. - A bug in cmctl causes `cmctl experimental install` to panic. ##### Breaking Changes The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image. If you run in an environment in which images cannot be pulled, be sure to include the new image. The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ##### Major Themes ##### New X.509 Features The cert-manager Certificate resource now allows you to configure a subset of "Other Name" SANs, which are described in the [Subject Alternative Name section of RFC 5280](https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.6) (on page 37). We specifically support any `otherName` type with a `UTF-8` value, such as the [User Principal Name](https://docs.venafi.com/Docs/current/TopNav/Content/Certificates/r-UEP-support-SANs.php) or [`sAMAccountName`](https://learn.microsoft.com/en-us/windows/win32/ad/naming-properties). These are useful when issuing unique certificates for authenticating with LDAP systems such as Microsoft Active Directory. For example you can create certificates with this block in the spec: otherNames: - oid: 1.3.6.1.4.1.311.20.2.3 # UPN OID utf8Value: upn@domain.local The feature is still in alpha stage and requires you to [enable the `OtherName` feature flag in the controller and webhook components](../../installation/configuring-components.md#feature-gates). ##### New CA certificate Features You can now specify the X.509 v3 Authority Information Accessors extension, with URLs for certificates issued by the CA issuer. Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ##### Security An ongoing security audit of the cert-manager code revealed some weaknesses which we have addressed in this release, such as using more secure default settings in the HTTP servers that serve metrics, healthz and pprof endpoints. This will help mitigate denial-of-service attacks against those important services. All the cert-manager containers are now configured with read only root file system by default, to prevent unexpected changes to the file system of the OCI image. And it is now possible to configure the metrics server to use HTTPS rather than HTTP, so that clients can verify the identity of the metrics server. ##### Other The liveness probe of the cert-manager controller Pod is now enabled by default. There is a new option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS. ##### Community Thanks again to all open-source contributors with commits in this release, including: - [@ABWassim](https://github.com/ABWassim) - [@JoeNorth](https://github.com/JoeNorth) - [@allenmunC1](https://github.com/allenmunC1) - [@asapekia](https://github.com/asapekia) - [@jeremycampbell](https://github.com/jeremycampbell) - [@jkroepke](https://github.com/jkroepke) - [@jsoref](https://github.com/jsoref) - [@lauraseidler](https://github.com/lauraseidler) - [@pevidex](https://github.com/pevidex) - [@phillebaba](https://github.com/phillebaba) - [@snorwin](https://github.com/snorwin) - [@tanujd11](https://github.com/tanujd11) - [@tberreis](https://github.com/tberreis) - [@vinny](https://github.com/vinny) Thanks also to the following cert-manager maintainers for their contributions during this release: - [@SgtCoDFish](https://github.com/SgtCoDFish) - [@SpectralHiss](https://github.com/SpectralHiss) - [@ThatsMrTalbot](https://github.com/ThatsMrTalbot) - [@hawksight](https://github.com/hawksight) - [@inteon](https://github.com/inteon) - [@maelvls](https://github.com/maelvls) - [@wallrj](https://github.com/wallrj) Equally thanks to everyone who provided feedback, helped users and raised issues on GitHub and Slack and joined our meetings! Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://github.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. ##### Changes ##### Feature - ACME challenge solver Pod for HTTP01 will get a default annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "true"`. You can provide an annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"` in your `podTemplate` if you don't like this. ([#6349](cert-manager/cert-manager#6349), [@jsoref](https://github.com/jsoref)) - Added a clock skew detector liveness probe that will force a restart in case we detect a skew between the internal monotonic clock and the system clock of more than 5 minutes. Also, the controller's liveness probe is now enabled by default. ([#6328](cert-manager/cert-manager#6328), [@inteon](https://github.com/inteon)) - Added a new flag (--dynamic-serving-leaf-duration) that can adjust the lifetime of the dynamic leaf certificates ([#6552](cert-manager/cert-manager#6552), [@allenmunC1](https://github.com/allenmunC1)) - Added support for `otherName` SANS in Certificates ([#6404](cert-manager/cert-manager#6404), [@SpectralHiss](https://github.com/SpectralHiss)) - Added the option to specify the X.509 v3 Authority Information Accessors extension CA Issuers URLs for certificates issued by the CA issuer. ([#6486](cert-manager/cert-manager#6486), [@jeremycampbell](https://github.com/jeremycampbell-okta)) - Adds cert-manager's new core infrastructure initiative badge! See more details on https://www.bestpractices.dev/projects/8079 ([#6497](cert-manager/cert-manager#6497), [@SgtCoDFish](https://github.com/SgtCoDFish)) - All Pods are now configured with `readOnlyRootFilesystem` by default. ([#6453](cert-manager/cert-manager#6453), [@wallrj](https://github.com/wallrj)) - MAYBE BREAKING: The startupapicheck job is now handled by an entirely new container called "startupapicheck". This replaces the previous ctl container. If you run in an environment in which images cannot be pulled, be sure to include the new container. ([#6549](cert-manager/cert-manager#6549), [@SgtCoDFish](https://github.com/SgtCoDFish)) - New option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS[#12](cert-manager/cert-manager#12) keystores. Fixes issues [#5957](cert-manager/cert-manager#5957) and [#6523](cert-manager/cert-manager#6523). ([#6548](cert-manager/cert-manager#6548), [@snorwin](https://github.com/snorwin)) - The ACME HTTP01 solver Pod is now configured with `readOnlyRootFilesystem: true` ([#6462](cert-manager/cert-manager#6462), [@wallrj](https://github.com/wallrj)) - Updates the AWS SDK for Go to 1.48.7 to support Amazon EKS Pod Identity ([#6519](cert-manager/cert-manager#6519), [@JoeNorth](https://github.com/JoeNorth)) - Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ([#6500](cert-manager/cert-manager#6500), [@tanujd11](https://github.com/tanujd11)) - ⚠️ potentially breaking ⚠️: The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ([#6053](cert-manager/cert-manager#6053), [@inteon](https://github.com/inteon)) - Add TLS support to the metrics endpoint through either a certificate file or through dynamically issued certificates ([#6574](cert-manager/cert-manager#6574), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Helm Chart: allow changing the default Deployment `revisionHistoryLimit` ([#6248](cert-manager/cert-manager#6248), [@tberreis](https://github.com/tberreis)) - Security: Limit the size of the response body read from HTTP requests by cert-manager. ([#6619](cert-manager/cert-manager#6619), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Support custom `spec.namespaceSelector` for webhooks ([#6638](cert-manager/cert-manager#6638), [@jkroepke](https://github.com/jkroepke)) ##### Bug or Regression - BUGFIX\[helm]: Fix issue where webhook feature gates were only set if controller feature gates are set. ([#6380](cert-manager/cert-manager#6380), [@asapekia](https://github.com/asapekia)) - Controller ConfigMap is now created only if `.Values.config` is set. ([#6357](cert-manager/cert-manager#6357), [@ABWassim](https://github.com/ABWassim)) - Fix runaway bug caused by multiple Certificate resources that point to the same Secret resource. ([#6406](cert-manager/cert-manager#6406), [@inteon](https://github.com/inteon)) - Fix(helm): templating of required value in controller and webhook ConfigMap resources ([#6435](cert-manager/cert-manager#6435), [@ABWassim](https://github.com/ABWassim)) - Fixed a webhook validation error message when the key algorithm was invalid. ([#6571](cert-manager/cert-manager#6571), [@pevidex](https://github.com/pevidex)) - Fixed error messaging when setting up vault issuer ([#6433](cert-manager/cert-manager#6433), [@vinny](https://github.com/vinny-sabatini)) - `GHSA-vgf6-pvf4-34rq`: The webhook server now returns HTTP error 413 (Content Too Large) for requests with body size `>= 3MiB`. This is to mitigate DoS attacks that attempt to crash the webhook process by sending large requests that exceed the available memory. The webhook server now returns HTTP error 400 (Bad Request) if the request contains an empty body. The webhook server now returns HTTP error 500 (Internal Server Error) rather than crashing, if the code panics while handling a request. ([#6498](cert-manager/cert-manager#6498), [@inteon](https://github.com/inteon)) - Increase the default webhook timeout to its maximum value of 30 seconds, so that the underlying timeout error message has more chance of being returned to the end user. ([#6488](cert-manager/cert-manager#6488), [@wallrj](https://github.com/wallrj)) - Listeners that do not support TLS on Gateway resources will now not raise `BadConfig` warnings anymore ([#6347](cert-manager/cert-manager#6347), [@lauraseidler](https://github.com/lauraseidler)) - Mitigate potential Slowloris attacks by setting `ReadHeaderTimeout` in all `http.Server` instances ([#6534](cert-manager/cert-manager#6534), [@wallrj](https://github.com/wallrj)) - The Venafi issuer now properly resets the certificate and should no longer get stuck with `WebSDK CertRequest Module Requested Certificate` or `This certificate cannot be processed while it is in an error state. Fix any errors, and then click Retry.`. ([#6398](cert-manager/cert-manager#6398), [@maelvls](https://github.com/maelvls)) - Update experimental install and uninstall commands to have flag parity with the rest of the CLI ([#6562](cert-manager/cert-manager#6562), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Webhook ConfigMap if now created only if `.Values.webhook.config` is set. ([#6360](cert-manager/cert-manager#6360), [@ABWassim](https://github.com/ABWassim)) - BUGFIX: Ensure `otherName` SAN changes in Certificate resources trigger re-issuance. ([#6620](cert-manager/cert-manager#6620), [@SpectralHiss](https://github.com/SpectralHiss)) - Bugfix: Publish the `startupapicheck` image to `quay.io` ([#6609](cert-manager/cert-manager#6609), [@wallrj](https://github.com/wallrj)) ##### Other (Cleanup or Flake) - Cert-manager is now built with Go 1.21.5 ([#6545](cert-manager/cert-manager#6545), [@wallrj](https://github.com/wallrj)) - Bump Go to `1.21.3` to address `CVE-2023-39325`. Also bumps base images. ([#6410](cert-manager/cert-manager#6410), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Bump `golang.org/x/net v0.15.0 => v0.17.0` as part of addressing `CVE-2023-44487` / `CVE-2023-39325` ([#6427](cert-manager/cert-manager#6427), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Check code for unintended use of `crypto/md5`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G501). ([#6581](cert-manager/cert-manager#6581), [@wallrj](https://github.com/wallrj)) - Check code for unintended use of `crypto/sha1`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G505). ([#6579](cert-manager/cert-manager#6579), [@wallrj](https://github.com/wallrj)) - Check code for unintended use of weak random number generator (`math/rand` instead of `crypto/rand`); using `golangci-lint` / `gosec` (G404). ([#6582](cert-manager/cert-manager#6582), [@wallrj](https://github.com/wallrj)) - Cleanup: Restrict MutatingWebhookConfiguration to only CertificateRequest resources ([#6311](cert-manager/cert-manager#6311), [@hawksight](https://github.com/hawksight)) - Deprecated `pkg/util.RandStringRunes` and `pkg/controller/test.RandStringBytes`. Use `k8s.io/apimachinery/pkg/util/rand.String` instead. ([#6585](cert-manager/cert-manager#6585), [@wallrj](https://github.com/wallrj)) - Enabled verbose logging in startupapicheck by default, so that if it fails, users can know exactly what caused the failure. ([#6495](cert-manager/cert-manager#6495), [@wallrj](https://github.com/wallrj)) - Fix gosec G601: Implicit memory aliasing of items from a range statement ([#6551](cert-manager/cert-manager#6551), [@wallrj](https://github.com/wallrj)) - Fix handling of serial numbers in literal certificate subjects. Previously a serial number could be specified in `subject.serialNumber` while using a literal certificate subject. This was a mistake and has been fixed. ([#6533](cert-manager/cert-manager#6533), [@inteon](https://github.com/inteon)) - The end-to-end tests can now test the cert-manager Vault Issuer on an OpenShift cluster. ([#6391](cert-manager/cert-manager#6391), [@wallrj](https://github.com/wallrj)) - Update cert-manager's distroless base images from Debian 11 to Debian 12. This should have no practical effects on users. ([#6583](cert-manager/cert-manager#6583), [@inteon](https://github.com/inteon)) - Updated all code using GatewayAPI to use the now GA v1 APIs ([#6559](cert-manager/cert-manager#6559), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6369](cert-manager/cert-manager#6369), [@inteon](https://github.com/inteon)) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#6366](cert-manager/cert-manager#6366), [@inteon](https://github.com/inteon)) - Use the new generic `sets.Set` type in place of the deprecated `sets.String`. ([#6586](cert-manager/cert-manager#6586), [@wallrj](https://github.com/wallrj)) - cert-manager is now built with Go `v1.21.6` ([#6628](cert-manager/cert-manager#6628), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Update the Azure SDK and remove deprecated `autorest` dependency ([#5452](cert-manager/cert-manager#5452), [@phillebaba](https://github.com/phillebaba)) - The cert-manager E2E tests can now be run on Kubernetes 1.29 ([#6641](cert-manager/cert-manager#6641), [@wallrj](https://github.com/wallrj)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/358 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

snorwin added 2 commits December 12, 2023 14:27

pkcs12 encoding with different algorithms

b8f4f3b

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

generate manifests

c583278

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration labels Dec 12, 2023

enhance unit tests

56dcb3e

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2023

jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Dec 12, 2023

fix controller-gen errors

b79e73f

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

snorwin force-pushed the modern-pkcs12 branch from f4a1eda to b79e73f Compare December 12, 2023 17:26

jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 12, 2023

jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2023

update internal api for the conversion logic

9185ca3

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

inteon reviewed Dec 13, 2023

View reviewed changes

internal/apis/certmanager/v1alpha2/types_certificate.go Outdated Show resolved Hide resolved

snorwin added 2 commits December 13, 2023 12:00

apply PR feedback

b8ad8a3

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

backport comment to internal api

879ec53

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

inteon reviewed Dec 13, 2023

View reviewed changes

internal/apis/certmanager/v1alpha2/types_certificate.go Outdated Show resolved Hide resolved

jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 13, 2023

snorwin requested a review from inteon December 14, 2023 12:28

SgtCoDFish requested changes Dec 14, 2023

View reviewed changes

pkg/controller/certificates/issuing/internal/keystore.go Outdated Show resolved Hide resolved

pkg/controller/certificates/issuing/internal/keystore.go Show resolved Hide resolved

apply PR feedback

ebf58b9

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

snorwin requested a review from SgtCoDFish December 15, 2023 10:04

SgtCoDFish approved these changes Dec 15, 2023

View reviewed changes

jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2023

inteon added this to the 1.14 milestone Dec 18, 2023

inteon approved these changes Dec 20, 2023

View reviewed changes

update API comments

24794fe

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023

inteon reviewed Dec 20, 2023

View reviewed changes

inteon self-assigned this Jan 3, 2024

inteon force-pushed the modern-pkcs12 branch from ebf4d98 to 2f7a61e Compare January 3, 2024 12:18

rename Algorithms to Profile

8223df9

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

inteon force-pushed the modern-pkcs12 branch from 2f7a61e to 8223df9 Compare January 3, 2024 12:45

jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 3, 2024

jetstack-bot merged commit 4af78fe into cert-manager:master Jan 3, 2024
7 checks passed

snorwin deleted the modern-pkcs12 branch January 3, 2024 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New option to specify encryption and MAC algorithms for PKCS#12 keystores. #6548

New option to specify encryption and MAC algorithms for PKCS#12 keystores. #6548

snorwin commented Dec 12, 2023 •

edited

jetstack-bot commented Dec 12, 2023

inteon commented Dec 12, 2023

snorwin commented Dec 12, 2023

inteon commented Dec 12, 2023

snorwin commented Dec 12, 2023

snorwin commented Dec 13, 2023

SgtCoDFish left a comment

SgtCoDFish commented Dec 14, 2023

SgtCoDFish left a comment

inteon left a comment

jetstack-bot commented Dec 20, 2023

inteon Dec 20, 2023

snorwin Dec 20, 2023

inteon Jan 2, 2024

SgtCoDFish Jan 2, 2024

inteon Jan 2, 2024

inteon Jan 3, 2024

inteon commented Dec 20, 2023 •

edited

inteon commented Jan 2, 2024

erikgb commented Jan 2, 2024

inteon commented Jan 3, 2024

New option to specify encryption and MAC algorithms for PKCS#12 keystores. #6548

New option to specify encryption and MAC algorithms for PKCS#12 keystores. #6548

Conversation

snorwin commented Dec 12, 2023 • edited

Pull Request Motivation

Kind

Release Note

jetstack-bot commented Dec 12, 2023

inteon commented Dec 12, 2023

snorwin commented Dec 12, 2023

inteon commented Dec 12, 2023

snorwin commented Dec 12, 2023

snorwin commented Dec 13, 2023

SgtCoDFish left a comment

Choose a reason for hiding this comment

SgtCoDFish commented Dec 14, 2023

SgtCoDFish left a comment

Choose a reason for hiding this comment

inteon left a comment

Choose a reason for hiding this comment

jetstack-bot commented Dec 20, 2023

inteon Dec 20, 2023

Choose a reason for hiding this comment

snorwin Dec 20, 2023

Choose a reason for hiding this comment

inteon Jan 2, 2024

Choose a reason for hiding this comment

SgtCoDFish Jan 2, 2024

Choose a reason for hiding this comment

inteon Jan 2, 2024

Choose a reason for hiding this comment

inteon Jan 3, 2024

Choose a reason for hiding this comment

inteon commented Dec 20, 2023 • edited

inteon commented Jan 2, 2024

erikgb commented Jan 2, 2024

inteon commented Jan 3, 2024

snorwin commented Dec 12, 2023 •

edited

inteon commented Dec 20, 2023 •

edited