Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secretTemplate to Certificate resources created by ingress-shim #6839

Merged
merged 3 commits into from Mar 14, 2024
Merged

Add secretTemplate to Certificate resources created by ingress-shim #6839

merged 3 commits into from Mar 14, 2024

Conversation

mangeshhambarde
Copy link
Contributor

@mangeshhambarde mangeshhambarde commented Mar 7, 2024 •
edited

Pull Request Motivation

These are the changes for implementing #6838.

This allows ingress-shim users to set the secretTemplate field on generated Certificate resources. This makes using secret sync tools (e.g. kubernetes-reflector) much simpler for ingress-shim users.

Added a new Ingress annotation cert-manager.io/secret-template whose value is a JSON representation of secretTemplate.

Kind

feature

Release Note

Added a new Ingress annotation for copying specific Ingress annotations to Certificate's secretTemplate

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2024
@jetstack-bot
Copy link
Collaborator

Hi @mangeshhambarde. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2024
This was referenced Mar 12, 2024
Closed
Open
@mangeshhambarde
New Ingress annotation for copying custom annotations to secret template
efe2e06 
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
@mangeshhambarde
Add tests
717269e 
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
@mangeshhambarde mangeshhambarde force-pushed the ingress-annotations-for-secret-template branch from 1ff6f6e to 44a0e3f Compare March 13, 2024 14:22
@mangeshhambarde
JSON encoded secretTemplate as Ingress annotation
f3bfc93 
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
@mangeshhambarde mangeshhambarde force-pushed the ingress-annotations-for-secret-template branch from 44a0e3f to f3bfc93 Compare March 13, 2024 14:40
SgtCoDFish
SgtCoDFish approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks great, thank you for this! Feels like we can be confident about this with the tests being there 😁 🚀

@SgtCoDFish
Copy link
Member

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2024
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
inteon
inteon reviewed Mar 14, 2024
View reviewed changes
pkg/controller/certificate-shim/sync_test.go
Namespace: gen.DefaultTestNamespace,
Annotations: map[string]string{
cmapi.IngressClusterIssuerNameAnnotationKey: "issuer-name",
cmapi.IngressSecretTemplate: `{ "annotations": { "example-annotation" : "dummy-value" }, "labels": { "example-label" : "dummy-value" } }`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be easier to read and create these annotations if there was a separate annotation for SecretTemplateAnnotations and SecretTemplateLabels.

@SgtCoDFish
Copy link
Member

/test pull-cert-manager-master-e2e-v1-28-upgrade

@jetstack-bot jetstack-bot merged commit 5213a53 into cert-manager:master Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoref jsoref jsoref left review comments

@inteon inteon inteon left review comments

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mangeshhambarde @jetstack-bot @SgtCoDFish @jsoref @inteon