Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add very useful values common with the main Cert-manager chart #126

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Add very useful values common with the main Cert-manager chart #126

merged 1 commit into from
Feb 21, 2023

Conversation

MaesterZ
Copy link
Contributor

@MaesterZ MaesterZ commented Dec 16, 2022 •
edited

New values like in https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml

  • commonLabels
  • daemonSetAnnotations
  • podAnnotations
  • podLabels
  • affinity

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Dec 16, 2022
@jetstack-bot
Copy link
Contributor

Hi @MaesterZ. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2022
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 16, 2022
@MaesterZ
Copy link
Contributor Author

MaesterZ commented Dec 16, 2022 •
edited

Should we bump the chart API version?

[ERROR] Chart.yaml: chart type is not valid in apiVersion 'v1'. It is valid in apiVersion 'v2'

Edit: jetstack/google-cas-issuer#96 (comment)

Yes. Helm v2 (apiVersion: v1) was deprecated in November 2020.

@MaesterZ
Copy link
Contributor Author

/assign @munnerz

@inteon
Copy link
Member

inteon commented Feb 9, 2023

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2023
@MaesterZ
Copy link
Contributor Author

MaesterZ commented Feb 9, 2023

Fixed the values comments to get a description everywhere and updated the README.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2023
@MaesterZ MaesterZ force-pushed the add-values branch 2 times, most recently from 7b305c1 to 7145394 Compare February 20, 2023 14:53
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2023
@inteon
Copy link
Member

inteon commented Feb 21, 2023

Thank you for the improvements!
/approve
/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Feb 21, 2023
@inteon
Copy link
Member

inteon commented Feb 21, 2023

@MaesterZ can you sign all your commits?

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 21, 2023
@MaesterZ
Add very useful values common with the main Cert-manager chart
17c9f74 
Signed-off-by: MaesterZ <22374424+MaesterZ@users.noreply.github.com>
@MaesterZ
Copy link
Contributor Author

Done @inteon, normalized the resources block using with like in cert-manager helm chart.

@inteon
Copy link
Member

inteon commented Feb 21, 2023

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@inteon inteon added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: inteon, MaesterZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit c88dfc2 into cert-manager:main Feb 21, 2023
@MaesterZ MaesterZ deleted the add-values branch March 22, 2023 12:35
@MaesterZ
Copy link
Contributor Author

Is that enough to get a 0.5.1 or 0.6.0 Helm chart release?

@laupow laupow mentioned this pull request Jun 6, 2023
Closed
munnerz
munnerz reviewed Sep 22, 2023
View reviewed changes
deploy/charts/csi-driver/Chart.yaml
@@ -1,4 +1,4 @@
apiVersion: v1
apiVersion: v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? 👀 why have we changed the chart's api version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

@inteon inteon inteon left review comments

Assignees

@munnerz munnerz

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaesterZ @jetstack-bot @inteon @munnerz