Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest CSI sidecar container images from registry.k8s.io #137

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Feb 15, 2023

k8s.gcr.io registry is deprecated and to be shut down https://groups.google.com/a/kubernetes.io/g/dev/c/DYZYNQ_A6_c

This PR changes the registry of upstream CSI driver sidecar images to the new registry.k8s.io and also bumps to the latest minor versions of those images. I've tested that CSI driver with these images work as expected.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
As k8s.gcr.io is deprecated

Signed-off-by: irbekrm <irbekrm@gmail.com>
@inteon
Copy link
Member

inteon commented Feb 16, 2023

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@inteon
Copy link
Member

inteon commented Feb 16, 2023

@irbekrm we are not in the OWNERS file
@SgtCoDFish

@SgtCoDFish
Copy link
Member

I've done a report of all the repos in the org so I know which ones are out of date.

Given that this is approved by an active cert-manager maintainer, I'll add the approved label manually here!

@SgtCoDFish SgtCoDFish added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: inteon, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit db43ac0 into cert-manager:main Feb 16, 2023
@irbekrm irbekrm deleted the k8s_registry branch February 16, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants