Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add digest to HELM chart #65

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Add digest to HELM chart #65

merged 3 commits into from
Feb 9, 2023

Conversation

MattiasGees
Copy link
Contributor

In some cases, you want to use the specific sha256 digest of an image instead of a tag.

I tested this on my local setup with and without digest.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 7, 2021
@jetstack-bot
Copy link
Contributor

Hi @MattiasGees. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2021
@MattiasGees
Copy link
Contributor Author

/assign @JoshVanL

@munnerz
Copy link
Member

munnerz commented Oct 7, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2021
JoshVanL
JoshVanL requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@JoshVanL JoshVanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MattiasGees, couple things from me.

/approve
/ok-to-test

deploy/charts/csi-driver/templates/daemonset.yaml Outdated Show resolved Hide resolved
deploy/charts/csi-driver/values.yaml Outdated Show resolved Hide resolved
deploy/charts/csi-driver/values.yaml Outdated Show resolved Hide resolved
deploy/charts/csi-driver/values.yaml Show resolved Hide resolved
@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 7, 2021
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2021
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2023
@MattiasGees @inteon
Add digest to HELM chart
a89fa4b 
In some cases you want to use the specific sha256 digest of an image instead of a tag.

Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
@MattiasGees @inteon
Address feedback
cc9f583 
Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2023
@inteon
fix remaining feedback
8a3cfcd 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Copy link
Member

inteon commented Feb 9, 2023

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, JoshVanL, MattiasGees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 0909b8e into cert-manager:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

@JoshVanL JoshVanL JoshVanL requested changes

@inteon inteon inteon left review comments

Assignees

@JoshVanL JoshVanL

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MattiasGees @jetstack-bot @munnerz @inteon @JoshVanL