Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller configmap refactor #97

Merged
merged 8 commits into from
Sep 20, 2021
Merged

Controller configmap refactor #97

merged 8 commits into from
Sep 20, 2021

Conversation

JoshVanL
Copy link
Contributor

This PR refactors the controller to reduce the memory usage by only caching ConfigMap metadata, and not attempt to update/create ConfigMaps in terminating Namespaces.

Adds a Subscription channel so that the controller will reconcile on ConfigMaps in all Namespaces when the root CA changes.

/assign @irbekrm

NONE

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2021
@JoshVanL
Copy link
Contributor Author

/retest

@JoshVanL
Refactor controller to use metadata only cache, and be safer on
0337d66 
namespace termination

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
irbekrm
irbekrm requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me- the usage of a Watch with Source is nice 👍🏼

I've added a couple nits and suggestions, else happy to approve.

pkg/controller/configmap.go Show resolved Hide resolved
pkg/controller/configmap.go Show resolved Hide resolved
pkg/controller/configmap.go Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
pkg/tls/tls.go Outdated Show resolved Hide resolved
@JoshVanL
Adds RootCASubscription to catch when root CA changes
d14dbbf 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Update controller options with new signatures
b73cc86 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Remove flag which is not used anymore
90a7771 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Update go modules with testify
6eb2417 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Fix tests, send subscription events correctly
2ad1edb 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL force-pushed the controller-configmap-refactor branch 4 times, most recently from 25908a5 to c68c6dc Compare September 20, 2021 10:25
@JoshVanL
Update root CAs from issuer _when_ the bytes are different
c68c6dc 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL closed this Sep 20, 2021
@JoshVanL JoshVanL reopened this Sep 20, 2021
irbekrm
irbekrm approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Sep 20, 2021 •
edited

@JoshVanL: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-istio-csr-k8s-v1-21-istio-v1-8 b57b269 link /test pull-istio-csr-k8s-v1-21-istio-v1-8
pull-istio-csr-k8s-v1-21-istio-v1-7 b57b269 link /test pull-istio-csr-k8s-v1-21-istio-v1-7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@JoshVanL
Adds empty carotation Makefile target to pass CI
f289c19 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@irbekrm
Copy link
Contributor

irbekrm commented Sep 20, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@jetstack-bot jetstack-bot merged commit 0be442c into cert-manager:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irbekrm irbekrm irbekrm approved these changes

Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @irbekrm