Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about client cert authentication for vault #1202

Draft
wants to merge 2 commits into
base: release-next
Choose a base branch
from
Draft

Add section about client cert authentication for vault #1202

wants to merge 2 commits into from

Conversation

joshmue
Copy link

@joshmue joshmue commented Mar 22, 2023

Documentation for cert-manager/cert-manager#4330

Things I was not sure about whether to do:

  • Add a block with an example kubernetes.io/tls Secret
  • Include other optional fields mountPath and name in example

@joshmue
Add section about client cert authentication for vault
0c568ea 
Signed-off-by: Joshua Mühlfort <muehlfort@gonicus.de>
@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2023
@joshmue joshmue mentioned this pull request Mar 22, 2023
Open
@netlify
Copy link

netlify bot commented Mar 22, 2023 •
edited

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 697486b
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64364ee8f9f77f0007b61611
😎 Deploy Preview https://deploy-preview-1202--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maelvls
Copy link
Member

maelvls commented Apr 7, 2023 •
edited

It looks good! I changed the base of your PR to the cert-manager:release-next branch so that it lands when we release 1.12.

@maelvls maelvls changed the base branch from master to release-next April 7, 2023 13:04
@joshmue @maelvls
Add "feature state" hint for vault client certificate authentication
697486b 
Co-authored-by: Maël Valais <mael@vls.dev>
Signed-off-by: Joshua Mühlfort <muehlfort@gonicus.de>
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshmue
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelvls maelvls maelvls left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshmue @maelvls @jetstack-bot