Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker testing and validation #1450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidnoyes
Copy link
Contributor

No description provided.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Mar 15, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2024
@davidnoyes
Copy link
Contributor Author

davidnoyes commented Mar 15, 2024

While making changes to the documentation, I found having to install NodeJS to run the Next server and linting validation wasn't always desired. I've created a dockerfile and makefile to perform the same tasks.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 6958121
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65f44edbd49def00072ee10d
😎 Deploy Preview https://deploy-preview-1450--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dockerfile Outdated Show resolved Hide resolved
Signed-off-by: David Noyes <david.noyes@venafi.com>
@ThatsMrTalbot
Copy link
Contributor

This does go against the conventions of the other repos, doing everything in docker by default.

But it also would make development easier, probably need some further opinions.

Other repos vendor all dependencies, though that could get heavy if we need to vendor nodejs itself

@davidnoyes
Copy link
Contributor Author

I'd say that this change doesn't set a new default but just adds another option.

@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@cert-manager-prow
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants