Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework 1.12 release notes #1477

Merged

Conversation

SgtCoDFish
Copy link
Member

  1. Moves the main release description to the top so it's easily visible without having to scroll all the way down to v1.12.0 to see it.
  2. Adds global known issues at the top of the doc so they're clearly visible
  3. Calls out the dupe secretname issue in global known issues
  4. Adds a note about 1.12 being LTS

Prompted by cert-manager/cert-manager#6992

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 682dac9
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/663e2a66af59d700085ce4ec
😎 Deploy Preview https://deploy-preview-1477--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Copy link

netlify bot commented May 10, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 4289737
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/663e2acb02ec2500087d3f1c
😎 Deploy Preview https://deploy-preview-1477--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 5c1f403
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/663e2b455afcf400084b31b7
😎 Deploy Preview https://deploy-preview-1477--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@SgtCoDFish
Copy link
Member Author

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@cert-manager-prow cert-manager-prow bot merged commit c580f5a into cert-manager:master May 10, 2024
3 of 4 checks passed
@SgtCoDFish SgtCoDFish deleted the dupe-secret-name-1.12 branch May 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants