Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react-icons #53

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

NFNChris
Copy link

The popular react-icons module provides FontAwesome icons (among others) in best practice SVG format. I have put together a pull request that provides optional support for this library, which at the time of writing has almost 350k weekly downloads.

@NFNChris
Copy link
Author

It seems listing "react-icons" as an "optionalDependency" in package.json results in an attempt to install it by default. I guess the alternative would be to simply leave it out of package.json entirely.

@NFNChris
Copy link
Author

This is building locally for me without issue. It seems the TeamCity build failure is unrelated to the code and something to do with the build environment:

[15:26:11][Step 1/1] System.InvalidOperationException: Could not find a 'develop' or 'master' branch, neither locally nor remotely. [15:26:11][Step 1/1] at GitVersion.BranchConfigurationCalculator.InheritBranchConfiguration (System.Boolean onlyEvaluateTrackedBranches, LibGit2Sharp.IRepository repository, LibGit2Sharp.Commit currentCommit, LibGit2Sharp.Branch currentBranch, System.Collections.Generic.KeyValuePair2[TKey,TValue] keyValuePair, GitVersion.BranchConfig branchConfiguration, GitVersion.Config config, System.Collections.Generic.IList1[T] excludedInheritBranches) [0x00229] in <57cedcc684654481ace045b6d7bcc156>:0 [15:26:11][Step 1/1] at GitVersion.BranchConfigurationCalculator.GetBranchConfiguration (LibGit2Sharp.Commit currentCommit, LibGit2Sharp.IRepository repository, System.Boolean onlyEvaluateTrackedBranches, GitVersion.Config config, LibGit2Sharp.Branch currentBranch, System.Collections.Generic.IList1[T] excludedInheritBranches) [0x00072] in <57cedcc684654481ace045b6d7bcc156>:0
[15:26:11][Step 1/1] at GitVersion.GitVersionContext.CalculateEffectiveConfiguration () [0x0001e] in <57cedcc684654481ace045b6d7bcc156>:0
[15:26:11][Step 1/1] at GitVersion.GitVersionContext..ctor (LibGit2Sharp.IRepository repository, LibGit2Sharp.Branch currentBranch, GitVersion.Config configuration, System.Boolean onlyEvaluateTrackedBranches, System.String commitId) [0x00110] in <57cedcc684654481ace045b6d7bcc156>:0
[15:26:11][Step 1/1] at GitVersion.GitVersionContext..ctor (LibGit2Sharp.IRepository repository, GitVersion.Config configuration, System.Boolean isForTrackingBranchOnly, System.String commitId) [0x00008] in <57cedcc684654481ace045b6d7bcc156>:0
[15:26:11][Step 1/1] at GitVersion.ExecuteCore+<>c__DisplayClass6_0.b__0 (LibGit2Sharp.IRepository repo) [0x00000] in <57cedcc684654481ace045b6d7bcc156>:0
[15:26:11][Step 1/1] at GitVersion.GitPreparer.WithRepository[TResult] (System.Func2[T,TResult] action) [0x0000c] in <57cedcc684654481ace045b6d7bcc156>:0 [15:26:11][Step 1/1] at GitVersion.ExecuteCore.ExecuteInternal (System.String targetBranch, System.String commitId, GitVersion.GitPreparer gitPreparer, GitVersion.IBuildServer buildServer, GitVersion.Config overrideConfig) [0x0002d] in <57cedcc684654481ace045b6d7bcc156>:0 [15:26:11][Step 1/1] at GitVersion.ExecuteCore.ExecuteGitVersion (System.String targetUrl, System.String dynamicRepositoryLocation, GitVersion.Authentication authentication, System.String targetBranch, System.Boolean noFetch, System.String workingDirectory, System.String commitId, GitVersion.Config overrideConfig) [0x000c7] in <57cedcc684654481ace045b6d7bcc156>:0 [15:26:11][Step 1/1] at GitVersion.SpecifiedArgumentRunner.Run (GitVersion.Arguments arguments, GitVersion.Helpers.IFileSystem fileSystem) [0x00074] in <57cedcc684654481ace045b6d7bcc156>:0 [15:26:11][Step 1/1] at GitVersion.Program.VerifyArgumentsAndRun () [0x00124] in <57cedcc684654481ace045b6d7bcc156>:0

@chadly
Copy link
Owner

chadly commented Jun 19, 2019

Thanks for this!

I'm wondering if it makes sense to just do a major version bump and include react-icons as a normal dependency.

@chadly chadly requested a review from mdarens June 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants