Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.0.0 #92

Merged
merged 2 commits into from Jan 10, 2018
Merged

Release 1.0.0 #92

merged 2 commits into from Jan 10, 2018

Conversation

stalniy
Copy link
Contributor

@stalniy stalniy commented Jan 10, 2018 •
edited

  • documentation
  • package.json

@stalniy stalniy mentioned this pull request Jan 10, 2018
Closed
@keithamus
Copy link
Member

@stalniy as part of this I think we should also drop Node < 4 from the package.json, and no longer support it. Thoughts?

@stalniy
Copy link
Contributor Author

stalniy commented Jan 10, 2018

@keithamus this was done in #91

@keithamus
Copy link
Member

Yup 😆 just saw that and merged.

@keithamus
Copy link
Member

If you rebase this against master, the tests will pass and I will merge 👍

@stalniy
Copy link
Contributor Author

stalniy commented Jan 10, 2018

Done! lets merge this :)

meeber
meeber approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@meeber meeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalniy stalniy merged commit 9a2d248 into chaijs:master Jan 10, 2018
@stalniy
Copy link
Contributor Author

stalniy commented Jan 10, 2018

@keithamus what do we need to do next to publish 1.0.0 on npm?

@keithamus
Copy link
Member

@stalniy could you please add some release notes to https://github.com/chaijs/chai-spies/releases/edit/untagged-c4a7ec2f780e17401aef and then hit Publish - CI will take care of the rest.

@stalniy
Copy link
Contributor Author

stalniy commented Jan 10, 2018

Cool! @keithamus what do you think about merging #93 in 1.0.0 as well?

@keithamus
Copy link
Member

Ideally the format should be:

General release notes go here

# Breaking Changes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)

# Bug Fixes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)

# Docs
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)

@stalniy stalniy deleted the chore/release branch January 11, 2018 12:55
@stalniy
Copy link
Contributor Author

stalniy commented Jan 11, 2018 •
edited

Sorry @keithamus , missed your last message. I will change the format. Do you use some tool to generate release notes?

@stalniy
Copy link
Contributor Author

stalniy commented Jan 11, 2018

Also npm i chai-spies@1.0.0 fails and npm i chai-spies@latest installs 0.7.1 version. Are there some issues with CI pipeline or you decided to postpone release to fix release notes format?

@stalniy
Copy link
Contributor Author

stalniy commented Jan 11, 2018

@keithamus updated release notes according to recommended format, also added Bug Fixes section. Could you please review draft, publish if everything is ok and make sure CI build updated version on npm?

@keithamus
Copy link
Member

I've gone ahead and manually published chai-spies@1.0.0 - it looks like it didnt publish on CI, I'll get around to fixing that later.

@keithamus keithamus mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meeber meeber meeber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stalniy @keithamus @meeber