Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue 108 #114

Merged
merged 1 commit into from Jul 6, 2020
Merged

fixes issue 108 #114

merged 1 commit into from Jul 6, 2020

Conversation

stalniy
Copy link
Contributor

@stalniy stalniy commented Jul 5, 2020 •
edited

Originally was in #109 but it was not rebased on the last master

Fixes #108

CC: @xetoile

@stalniy stalniy requested a review from keithamus July 5, 2020 07:54
keithamus
keithamus approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stalniy stalniy merged commit df9ad8e into master Jul 6, 2020
@stalniy
Copy link
Contributor Author

stalniy commented Jul 6, 2020

@keithamus when can we publish a new version?

@stalniy stalniy deleted the fix/chai.restore branch July 6, 2020 10:27
@keithamus
Copy link
Member

@stalniy if you feel it's ready to cut a new version, do you want to create a PR, changing the package.json as per #92 and if CI doesn't work again I'll publish it manually 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restoring issue
2 participants
@stalniy @keithamus