Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to remove spies from object methods #41

Closed
wants to merge 1 commit into from

Conversation

wsb9
Copy link

@wsb9 wsb9 commented Nov 16, 2015

Feature is useful when you need to spy on system/browser APIs and restore it after test is done.

Test case for new functionality is included.

@keithamus
Copy link
Member

Hey @wsb9 thanks for the PR!

We've actually got a issue filed here: #38 in which we're trying to work out a design for how to do spy restoration.

I think I'd really like it to be outside of the spy object, so that we don't unnecessarily pollute the spied Functions namespace.

I really appreciate the work you've put into this, and I hope this doesn't put you off of contributing further -but I think for now I'm going to close this. I'd really like it if you gave some of your insight into #38 and we came up with a really nice design for this - and then we can look at making PRs.

@keithamus keithamus closed this Nov 16, 2015
@wsb9
Copy link
Author

wsb9 commented Nov 16, 2015

Oops, didn't noticed such thread, will take a look :)

@wsb9 wsb9 deleted the object-spy-removal branch November 16, 2015 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants