Whitelist .then from proxy check

chaijs · Jun 10, 2016 · 0c1d280 · 0c1d280
1 parent ef0f1a8
commit 0c1d280
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/lib/chai/utils/proxify.js b/lib/chai/utils/proxify.js
@@ -22,8 +22,11 @@ module.exports = function proxify (obj) {
 
   return new Proxy(obj, {
     get: function getProperty (target, property) {
-      // Don't throw error on Symbol properties such as Symbol.toStringTag
-      if (typeof property === 'string' && !Reflect.has(target, property))
+      // Don't throw error on Symbol properties such as Symbol.toStringTag, nor
+      // on .then because it's necessary for promise support.
+      if (typeof property === 'string' &&
+          property !== 'then' &&
+          !Reflect.has(target, property))
         throw Error('Invalid Chai property: ' + property);
 
       return target[property];

diff --git a/test/expect.js b/test/expect.js
@@ -28,6 +28,11 @@ describe('expect', function () {
     err(function () {
       expect(42).to.equal(42).pizza;
     }, 'Invalid Chai property: pizza');
+
+    // "then" is whitelisted from property validation for promise support
+    expect(function () {
+      expect(42).then;
+    }).to.not.throw();
   });
 
   it('no-op chains', function() {

diff --git a/test/should.js b/test/should.js
@@ -25,6 +25,11 @@ describe('should', function() {
     err(function () {
       (42).should.equal(42).pizza;
     }, 'Invalid Chai property: pizza');
+
+    // "then" is whitelisted from property validation for promise support
+    (function () {
+      (42).should.then;
+    }).should.not.throw();
   });
 
   it('no-op chains', function() {