Skip to content

Commit

Permalink
Merge pull request #575 from lucasfcosta/clean-browser-before-karma
Browse files Browse the repository at this point in the history
Clean browser before karma
  • Loading branch information
keithamus committed Dec 22, 2015
2 parents e1b504c + 95a5056 commit a4b253d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions CONTRIBUTING.md
Expand Up @@ -121,12 +121,9 @@ git checkout -b <topic-branch-name>

4. Commit your changes in logical chunks. Use Git's [interactive rebase](https://help.github.com/articles/interactive-rebase) feature to tidy up your commits before making them public.

5. Run you code to make sure it works.
5. Run you code to make sure it works. If you're still having problems please try to run `make clean` and then test your code again.

```bash
npm i
rm chai.js
make chai.js
npm test
# when finished running tests...
git checkout chai.js
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Expand Up @@ -61,17 +61,17 @@ test-cov: node_modules
--require ./test/bootstrap \
$(TESTS) \

test-phantom: chai.js
test-phantom: clean-browser chai.js
@printf "==> [Test :: Karma (PhantomJS)]\n"
@./node_modules/karma/bin/karma start \
--single-run --browsers PhantomJS

test-firefox: chai.js
test-firefox: clean-browser chai.js
@printf "==> [Test :: Karma (Firefox)]\n"
@./node_modules/karma/bin/karma start \
--browsers Firefox

test-sauce: chai.js
test-sauce: clean-browser chai.js
@printf "==> [Test :: Karma (Sauce)]\n"
@CHAI_TEST_ENV=sauce ./node_modules/karma/bin/karma start \
--single-run
Expand Down

0 comments on commit a4b253d

Please sign in to comment.