Merge pull request #724 from meeber/issue-718

Fix chai.use as ES6 named export
chaijs · Jun 9, 2016 · fd2cc2b · fd2cc2b
2 parents 89231de + a1c5ff7
commit fd2cc2b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/chai.js b/lib/chai.js
@@ -37,11 +37,11 @@ var util = require('./chai/utils');
 
 exports.use = function (fn) {
   if (!~used.indexOf(fn)) {
-    fn(this, util);
+    fn(exports, util);
     used.push(fn);
   }
 
-  return this;
+  return exports;
 };
 
 /*!

diff --git a/test/plugins.js b/test/plugins.js
@@ -21,4 +21,20 @@ describe('plugins', function () {
       chai.use(plugin);
     }).to.not.throw();
   });
+
+  it('.use detached from chai object', function () {
+    function anotherPlugin (chai) {
+      Object.defineProperty(chai.Assertion.prototype, 'moreTesting', {
+        get: function () {
+          return 'more success';
+        }
+      });
+    }
+
+    var use = chai.use;
+    use(anotherPlugin);
+
+    var expect = chai.expect;
+    expect(expect('').moreTesting).to.equal('more success');
+  });
 });