Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chai.Assertion is no longer exported #1375

Closed
rbruckheimer opened this issue Mar 2, 2021 · 7 comments
Closed

chai.Assertion is no longer exported #1375

rbruckheimer opened this issue Mar 2, 2021 · 7 comments

Comments

@rbruckheimer
Copy link

index.mjs is not exporting Assertion. It needs a line:
export const Assertion = chai.Assertion;
I discovered this when attempting to upgrade from 4.2.0 to 4.3.0.

I also noticed that the code in the 4.3.0 tag here on GitHub does not match what's on npm. npm seems to be more like the master branch. Can you check it out please?

@keithamus
Copy link
Member

Can you please confirm if this problem still exists in the 4.3.1 release? Thanks

@rbruckheimer
Copy link
Author

The code now matches between the commit 8a24666 (4.3.1 tag) and npm.
However, the export issue still exists.

@keithamus
Copy link
Member

Would you like to submit a PR for the 4.x.x branch please?

@rbruckheimer
Copy link
Author

#1378

@keithamus
Copy link
Member

Fixed in 4.3.3

@rbruckheimer
Copy link
Author

Keith, the 4.3.3 release note says AssertionError is reintroduced, but it's really Assertion being reintroduced. If you can fix it it will help others find the fixed version.

@keithamus
Copy link
Member

Oops fixed!

This was referenced Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants