Update smart-contracts #6870

renovate · 2020-10-01T07:28:24Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@openzeppelin/contracts (source)	`3.1.0` -> `3.4.2`
@openzeppelin/hardhat-upgrades	`1.9.0` -> `1.10.0`
@openzeppelin/upgrades-core	`1.8.0` -> `1.9.0`
@typescript-eslint/eslint-plugin	`4.3.0` -> `4.31.0`
@typescript-eslint/parser	`4.3.0` -> `4.31.0`
chai (source)	`4.2.0` -> `4.3.4`
eslint (source)	`7.8.1` -> `7.32.0`
eslint-plugin-prettier	`3.1.4` -> `3.4.1`
ethers	`5.3.1` -> `5.4.6`
hardhat (source)	`2.5.0` -> `2.6.4`
lint-staged	`11.0.0` -> `11.1.2`
prettier (source)	`2.1.1` -> `2.4.0`
web3	`1.3.6` -> `1.5.2`

Release Notes

OpenZeppelin/openzeppelin-contracts

`v3.4.2`

TimelockController: Add additional isOperationReady check.

`v3.4.1`

ERC721: made _approve an internal function (was private).

`v3.4.0`

Compare Source

BeaconProxy: added new kind of proxy that allows simultaneous atomic upgrades. (#2411)
EIP712: added helpers to verify EIP712 typed data signatures on chain. (#2418)
ERC20Permit: added an implementation of the ERC20 permit extension for gasless token approvals. (#2237)
Presets: added token presets with preminted fixed supply ERC20PresetFixedSupply and ERC777PresetFixedSupply. (#2399)
Address: added functionDelegateCall, similar to the existing functionCall. (#2333)
Clones: added a library for deploying EIP 1167 minimal proxies. (#2449)
Context: moved from contracts/GSN to contracts/utils. (#2453)
PaymentSplitter: replace usage of .transfer() with Address.sendValue for improved compatibility with smart wallets. (#2455)
UpgradeableProxy: bubble revert reasons from initialization calls. (#2454)
SafeMath: fix a memory allocation issue by adding new SafeMath.tryOp(uint,uint)→(bool,uint) functions. SafeMath.op(uint,uint,string)→uint are now deprecated. (#2462)
EnumerableMap: fix a memory allocation issue by adding new EnumerableMap.tryGet(uint)→(bool,address) functions. EnumerableMap.get(uint)→string is now deprecated. (#2462)
ERC165Checker: added batch getSupportedInterfaces. (#2469)
RefundEscrow: beneficiaryWithdraw will forward all available gas to the beneficiary. (#2480)
Many view and pure functions have been made virtual to customize them via overrides. In many cases this will not imply that other functions in the contract will automatically adapt to the overridden definitions. People who wish to override should consult the source code to understand the impact and if they need to override any additional functions to achieve the desired behavior.

Security Fixes

ERC777: fix potential reentrancy issues for custom extensions to ERC777. (#2483)

If you're using our implementation of ERC777 from version 3.3.0 or earlier, and you define a custom _beforeTokenTransfer function that writes to a storage variable, you may be vulnerable to a reentrancy attack. If you're affected and would like assistance please write to security@openzeppelin.com. Read more in the pull request.

`v3.3.0`

Compare Source

Now supports both Solidity 0.6 and 0.7. Compiling with solc 0.7 will result in warnings. Install the solc-0.7 tag to compile without warnings.
Address: added functionStaticCall, similar to the existing functionCall. (#2333)
TimelockController: added a contract to augment access control schemes with a delay. (#2354)
EnumerableSet: added Bytes32Set, for sets of bytes32. (#2395)

`v3.2.0`

Compare Source

New features

Proxies: added the proxy contracts from OpenZeppelin SDK. (#2335)

Proxy changes with respect to OpenZeppelin SDK

Aside from upgrading them from Solidity 0.5 to 0.6, we've changed a few minor things from the proxy contracts as they were found in OpenZeppelin SDK.

UpgradeabilityProxy was renamed to UpgradeableProxy.
AdminUpgradeabilityProxy was renamed to TransparentUpgradeableProxy.
Proxy._willFallback was renamed to Proxy._beforeFallback.
UpgradeabilityProxy._setImplementation and AdminUpgradeabilityProxy._setAdmin were made private.

Improvements

Address.isContract: switched from extcodehash to extcodesize for less gas usage. (#2311)

Breaking changes

ERC20Snapshot: switched to using _beforeTokenTransfer hook instead of overriding ERC20 operations. (#2312)

This small change in the way we implemented ERC20Snapshot may affect users who are combining this contract with
other ERC20 flavors, since it no longer overrides _transfer, _mint, and _burn. This can result in having to remove Solidity override(...) specifiers in derived contracts for these functions, and to instead have to add it for _beforeTokenTransfer. See Using Hooks in the documentation.

OpenZeppelin/openzeppelin-upgrades

`v1.10.0`

Compare Source

typescript-eslint/typescript-eslint

`v4.31.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.30.0`

Compare Source

Features

typescript-estree: add support for class static blocks (#3730) (f81831b)

4.29.3 (2021-08-23)

Note: Version bump only for package @typescript-eslint/parser

4.29.2 (2021-08-16)

Note: Version bump only for package @typescript-eslint/parser

4.29.1 (2021-08-09)

Note: Version bump only for package @typescript-eslint/parser

`v4.29.3`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.29.2`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.29.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.29.0`

Compare Source

Bug Fixes

typescript-estree: correct tty check (#3635) (62bcc93)
typescript-estree: ensure --fix works with singleRun mode (#3655) (99eca0d)

Features

ast-spec: make BaseNode & BaseToken more type-safe (#3560) (a6c5604)
typescript-estree: add support for custom module resolution (#3516) (d48429d)

4.28.5 (2021-07-26)

Note: Version bump only for package @typescript-eslint/typescript-estree

4.28.4 (2021-07-19)

Note: Version bump only for package @typescript-eslint/typescript-estree

4.28.3 (2021-07-12)

Note: Version bump only for package @typescript-eslint/typescript-estree

4.28.2 (2021-07-05)

Note: Version bump only for package @typescript-eslint/typescript-estree

4.28.1 (2021-06-28)

Note: Version bump only for package @typescript-eslint/typescript-estree

`v4.28.5`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.28.4`

Compare Source

Note: Version bump only for package @typescript-eslint/eslint-plugin

`v4.28.3`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.28.2`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.28.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.28.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.27.0`

Compare Source

Bug Fixes

typescript-estree: allow providing more one than one existing program in config (#3508) (4f1806e)

Features

allow user to provide TS program instance in parser options (#3484) (e855b18)

4.26.1 (2021-06-07)

Note: Version bump only for package @typescript-eslint/parser

`v4.26.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.26.0`

Compare Source

Bug Fixes

eslint-plugin: [no-type-alias] consider type imports as alias types (#3433) (d4f0774)

Features

eslint-plugin: [member-ordering] add callback as an ordering type of node (#3354) (d134b1f)
eslint-plugin: [space-infix-ops] Add support for Union and intersection of type declarations (#3360) (3d29323)

`v4.25.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.24.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.23.0`

Compare Source

Features

refactor to split AST specification out as its own module (#2911) (25ea953)

4.22.1 (2021-05-04)

Note: Version bump only for package @typescript-eslint/parser

`v4.22.1`

Compare Source

Note: Version bump only for package @typescript-eslint/eslint-plugin

`v4.22.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.21.0`

Compare Source

Bug Fixes

eslint-plugin: [no-type-alias] consider keyof as an alias (#3242) (329ef02)
eslint-plugin: [no-unnecessary-type-assertion] correct bad fix for angle bracket assertion (#3244) (265a039)
eslint-plugin: [restrict-plus-operands] consider template literal types as strings (#3234) (ccfd68e)
eslint-plugin: [strict-boolean-expressions] account for truthy literals (#3236) (0913f40)
eslint-plugin: always ignore assignments in no-unnecessary-type-assertion (#3235) (0221476)

Features

eslint-plugin: [no-unsafe-argument] add rule (#3256) (b1aa7dc), closes #791
eslint-plugin: [no-unsafe-call][no-unsafe-member-access] improve report messages for this for noImplicitThis (#3199) (b1b26c4)

`v4.20.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.19.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.18.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.17.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.16.1 (2021-03-01)

Note: Version bump only for package @typescript-eslint/parser

`v4.16.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.16.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.15.2 (2021-02-22)

Note: Version bump only for package @typescript-eslint/parser

4.15.1 (2021-02-15)

Note: Version bump only for package @typescript-eslint/parser

`v4.15.2`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.15.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.15.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.14.2 (2021-02-01)

Note: Version bump only for package @typescript-eslint/parser

4.14.1 (2021-01-25)

Note: Version bump only for package @typescript-eslint/parser

`v4.14.2`

Compare Source

Bug Fixes

eslint-plugin: [consistent-type-imports] incorrect handling of computed property type signatures (#2990) (58f2655), closes #2989
scope-manager: correctly reference generic parameters when decorator metadata is enabled (#2975) (7695ef3), closes #2972

`v4.14.1`

Compare Source

Bug Fixes

eslint-plugin: [sort-type-union-intersection-members] consider void as a nullish (#2944) (a241b25), closes #2940
scope-manager: fix incorrect handling of class decorators and class method default params (#2943) (e1eac83), closes #2941 #2942 #2751

`v4.14.0`

Compare Source

Features

add support for decorator metadata in scope analysis and in consistent-type-imports (#2751) (445e416), closes #2559

`v4.13.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.12.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.11.1 (2020-12-28)

Note: Version bump only for package @typescript-eslint/parser

`v4.11.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.11.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.10.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.9.1 (2020-12-07)

Note: Version bump only for package @typescript-eslint/parser

`v4.9.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.9.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.8.2 (2020-11-23)

Note: Version bump only for package @typescript-eslint/parser

4.8.1 (2020-11-17)

Note: Version bump only for package @typescript-eslint/parser

`v4.8.2`

Compare Source

Bug Fixes

eslint-plugin: [prefer-literal-enum-member] allow pure template literal strings (#2786) (f3bf6a1)

`v4.8.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.8.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.7.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

4.6.1 (2020-11-02)

Note: Version bump only for package @typescript-eslint/parser

`v4.6.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.6.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.5.0`

Compare Source

Bug Fixes

parser: minor fix regexp, map-filter to reduce (#2684) (f1329f6)

Features

typescript-estree: add flag EXPERIMENTAL_useSourceOfProjectReferenceRedirect (#2669) (90a5878)

4.4.1 (2020-10-12)

Note: Version bump only for package @typescript-eslint/parser

`v4.4.1`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

`v4.4.0`

Compare Source

Note: Version bump only for package @typescript-eslint/parser

chaijs/chai

`v4.3.4`

Compare Source

This fixes broken inspect behavior with bigints (#1321) (#1383) thanks @vapier

This releases fixed an engine incompatibility with 4.3.0

The 4.x.x series of releases will be compatible with Node 4.0. Please report any errors found in Node 4 as bugs, and they will be fixed.

The 5.x.x series, when released, will drop support for Node 4.0

This fix also ensures pathval is updated to 1.1.1 to fix CVE-2020-7751

`v4.3.0`

Compare Source

This is a minor release.

Not many changes have got in since the last release but this one contains a very important change (#1257) which will allow jest users to get better diffs. From this release onwards, jest users will be able to see which operator was used in their diffs. The operator is a property of the AssertionError thrown when assertions fail. This flag indicates what kind of comparison was made.

This is also an important change for plugin maintainers. Plugin maintainers will now have access to the operator flag, which they can have access to through an utilmethod calledgetOperator`.

Thanks to all the amazing people that contributed to this release.

New Features

Allow contain.oneOf to take an array of possible values (@voliva)
Adding operator attribute to assertion error (#1257) (@rpgeeganage)
The closeTo error message will now inform the user when a delta is required (@eouw0o83hf)

Docs

Add contains flag to oneOf documentation (@voliva)

Tests

Make sure that useProxy config is checked in overwriteProperty (@vieiralucas)
Add tests for contain.oneOf (@voliva )

Chores

Update mocha to version 6.1.4
Add node v10 and v12 to ci (@vieiralucas)
Drop support for node v4, v6 and v9 (@vieiralucas)
Fix sauce config for headless chrome (@meeber)
Update dev dependencies (@meeber)
Removed phantomjs dependency (#1204)

eslint/eslint

`v7.32.0`

Compare Source

3c78a7b Chore: Adopt eslint-plugin/prefer-message-ids rule internally (#14841) (Bryan Mishkin)
faecf56 Update: change reporting location for curly rule (refs #12334) (#14766) (Nitin Kumar)
d7dc07a Fix: ignore lines with empty elements (fixes #12756) (#14837) (Soufiane Boutahlil)
1bfbefd New: Exit on fatal error (fixes #13711) (#14730) (Antonios Katopodis)
ed007c8 Chore: Simplify internal no-invalid-meta rule (#14842) (Bryan Mishkin)
d53d906 Docs: Prepare data for website to indicate rules with suggestions (#14830) (Bryan Mishkin)
d28f2ff Docs: Reference eslint-config-eslint to avoid potential for staleness (#14805) (Brett Zamir)
8be8a36 Chore: Adopt eslint-plugin/require-meta-docs-url rule internally (#14823) (Bryan Mishkin)
f9c164f Docs: New syntax issue template (#14826) (Nicholas C. Zakas)
eba0c45 Chore: assertions on reporting loc in unicode-bom (refs #12334) (#14809) (Nitin Kumar)
ed945bd Docs: fix multiple broken links (#14833) (Sam Chen)
60df44c Chore: use actions/setup-node@v2 (#14816) (Nitin Kumar)
6641d88 Docs: Update README team and sponsors (ESLint Jenkins)

`v7.31.0`

Compare Source

efdbb12 Upgrade: @eslint/eslintrc to v0.4.3 (#14808) (Brandon Mills)
a96b05f Update: add end location to report in consistent-return (refs #12334) (#14798) (Nitin Kumar)
e0e8e30 Docs: update BUG_REPORT template (#14787) (Nitin Kumar)
39115c8 Docs: provide more context to no-eq-null (#14801) (gfyoung)
9a3c73c Docs: fix a broken link (#14790) (Sam Chen)
[ddffa8a](https://togithub.c

Configuration

📅 Schedule: "on the first day of the month" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

clemsos · 2021-09-13T11:21:25Z

Results of calculations have changed for some mysterious reasons...

Here are amounts emitted from recordKeyPurchase

before upgrade

0xcace1b78160ae76398f486c8a18044da0d66d86d Transfer(from=0x0000000000000000000000000000000000000000, to=0x90F79bf6EB2c4f870365E785982E1f101E93b906, value=9.999750006249843754)
0xcace1b78160ae76398f486c8a18044da0d66d86d Transfer(from=0x0000000000000000000000000000000000000000, to=0x70997970C51812dc3A010C7d01b50e0d17dc79C8, value=2.499937501562460938)

after update

0xcace1b78160ae76398f486c8a18044da0d66d86d Transfer(from=0x0000000000000000000000000000000000000000, to=0x90F79bf6EB2c4f870365E785982E1f101E93b906, value=6.000819852140709899)
0xcace1b78160ae76398f486c8a18044da0d66d86d Transfer(from=0x0000000000000000000000000000000000000000, to=0x70997970C51812dc3A010C7d01b50e0d17dc79C8, value=1.500204963035177474)

I see there were some update to MathSafe but that shouldn't affect the results I guess

clemsos · 2021-09-13T11:34:32Z

ok so it seems that the contracts have been optimized in new versions, so the value passed as estimatedGasForPurchase is too low - therefore not reaching the growth cap. Multiplying that value by 2 in the different tests solves the issue.

renovate bot requested a review from HardlyDifficult October 1, 2020 07:28

cla-bot bot added the cla-signed label Oct 1, 2020

renovate bot force-pushed the renovate/smart-contracts branch 10 times, most recently from b7c4c2f to 0e77339 Compare October 9, 2020 00:32

renovate bot force-pushed the renovate/smart-contracts branch 11 times, most recently from d8e0d3a to d821dd4 Compare October 16, 2020 15:00

renovate bot force-pushed the renovate/smart-contracts branch 7 times, most recently from a6cb1e0 to 8913036 Compare October 21, 2020 13:57

renovate bot force-pushed the renovate/smart-contracts branch 2 times, most recently from 0f4d9de to 6c3f301 Compare May 17, 2021 18:15

renovate bot force-pushed the renovate/smart-contracts branch 5 times, most recently from 40c26f5 to f109bc8 Compare May 26, 2021 05:16

julien51 force-pushed the renovate/smart-contracts branch from af3539f to f4e8498 Compare May 27, 2021 13:46

renovate bot force-pushed the renovate/smart-contracts branch from 7e1d820 to c2af7d5 Compare June 11, 2021 18:30

renovate bot force-pushed the renovate/smart-contracts branch 2 times, most recently from 78d96a7 to 247b0e8 Compare July 6, 2021 07:36

renovate bot force-pushed the renovate/smart-contracts branch 2 times, most recently from 38ab5d6 to 5641e58 Compare September 2, 2021 20:56

julien51 mentioned this pull request Sep 3, 2021

Migrate smart contracts extensions to hardhat #7503

Merged

9 tasks

renovate bot force-pushed the renovate/smart-contracts branch 9 times, most recently from 03b434e to 4a87596 Compare September 9, 2021 10:28

Update smart-contracts

5bcb963

renovate bot force-pushed the renovate/smart-contracts branch from 4a87596 to 5bcb963 Compare September 9, 2021 20:20

clemsos mentioned this pull request Sep 13, 2021

Contracts upgrade gas estimate fix #7548

Merged

6 tasks

julien51 closed this in #7548 Sep 13, 2021

renovate bot deleted the renovate/smart-contracts branch September 13, 2021 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update smart-contracts #6870

Update smart-contracts #6870

renovate bot commented Oct 1, 2020 •

edited

clemsos commented Sep 13, 2021 •

edited

clemsos commented Sep 13, 2021

Update smart-contracts #6870

Update smart-contracts #6870

Conversation

renovate bot commented Oct 1, 2020 • edited

Release Notes

Security Fixes

New features

Proxy changes with respect to OpenZeppelin SDK

Improvements

Breaking changes

Features

4.29.3 (2021-08-23)

4.29.2 (2021-08-16)

4.29.1 (2021-08-09)

Bug Fixes

Features

4.28.5 (2021-07-26)

4.28.4 (2021-07-19)

4.28.3 (2021-07-12)

4.28.2 (2021-07-05)

4.28.1 (2021-06-28)

Bug Fixes

Features

4.26.1 (2021-06-07)

Bug Fixes

Features

Features

4.22.1 (2021-05-04)

Bug Fixes

Features

4.16.1 (2021-03-01)

4.15.2 (2021-02-22)

4.15.1 (2021-02-15)

4.14.2 (2021-02-01)

4.14.1 (2021-01-25)

Bug Fixes

Bug Fixes

Features

4.11.1 (2020-12-28)

4.9.1 (2020-12-07)

4.8.2 (2020-11-23)

4.8.1 (2020-11-17)

Bug Fixes

4.6.1 (2020-11-02)

Bug Fixes

Features

4.4.1 (2020-10-12)

New Features

Docs

Tests

Chores

Configuration

clemsos commented Sep 13, 2021 • edited

clemsos commented Sep 13, 2021

renovate bot commented Oct 1, 2020 •

edited

clemsos commented Sep 13, 2021 •

edited