Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chai 4.3.x or higher doesn't run on IE 11 #1379

Closed
lnewson opened this issue Mar 3, 2021 · 3 comments
Closed

Chai 4.3.x or higher doesn't run on IE 11 #1379

lnewson opened this issue Mar 3, 2021 · 3 comments

Comments

@lnewson
Copy link
Contributor

lnewson commented Mar 3, 2021

Chai 4.3 introduced a regression via #1334 that causes chai to throw a syntax error on IE 11. This is because it's using an arrow function here which isn't supported on IE 11.

image

This is also causing the automated saucelab tests setup for Chai to fail: https://app.saucelabs.com/tests/2e7d344d051d40a9b1524d6df4b86a1b

@Trott
Copy link

Trott commented Mar 3, 2021

If I'm not mistaken, the cited commit only appears in Chai 4.3.1. In my tests, 4.3.0 worked for IE 11 but 4.3.1 does not. So perhaps the title of the issue should say 4.3.1 rather than 4.3.x`.

@rbruckheimer
Copy link

There was identified an inconsistency between what's in GitHub in 4.3.0 and what's on npm. npm had some changes from master in it, possibly this arrow function as well.

@keithamus
Copy link
Member

Fixed in 4.3.2.

Thanks everyone!

This was referenced Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants