unbox BigInt primitives in shouldGetter #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this @dwelle 👍 Please could you write a couple of tests just so we don't end up regressing this behaviour? Thanks! |
|
I've written tests for the unboxing behavior (for other types as well). Hopefully I didn't duplicate it from somewhere else. Used a custom assertion -- not sure if I should have used chai assertions for this (considering BigInt support isn't yet added). Also, it seems the makefile is broken on Windows --- at least the |
keithamus
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1321 so that global
shouldgetter unboxes primitive BigInt values.Lemme know if I should write any tests.