Fixing a typo in the getProperties() utility
#485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...where `subject` should apparently be `object`.
|
Yeah, adding better guidelines is on my long list of things to do. If you would like to submit a PR, I'd happily merge it 😉 As for this PR, thanks very much for your hard work. |
keithamus
added a commit
that referenced
this pull request
Jul 17, 2015
Fixing a typo in the `getProperties()` utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subjectshould apparently beobject.My apologies for creating a new pull request..the last one disappeared due to me resetting my master branch. Previous PR is here: #483
As requested, I rebased all my commits and removed the
chai.jsbuild. I think it would be helpful to add these guidelines to the README file, since I saw quite a few people running into these when opening PRs.