Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation of includeStack at config #768

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Conversation

vieiralucas
Copy link
Member

@vieiralucas vieiralucas commented Aug 12, 2016

Hello guys,

I was looking at #766, when suddenly, I had an OCD attack when I saw this poorly indented line 馃槃
I understand that this is clearly me being nitpicking and I will be totally fine if you think that this should not be merged.

Thanks

@keithamus
Copy link
Member

LGTM 馃槅

@meeber? @lucasfcosta? Could use your expert eyes here.

@meeber
Copy link
Contributor

meeber commented Aug 12, 2016

@keithamus I've reviewed the diff multiple times from multiple viewing angles (including turning my display upside down) and while I don't see any malicious code being injected here, I'm still highly suspicious of the Lucas Syndicate (especially this @vieiralucas character). It's my suspicion that this PR is an attempt to lull the Chai team into a sleepy daze in preparation for more nefarious PRs to come. But lacking proof, I have no choice but to say: LGTM

@meeber meeber merged commit 87c3be5 into chaijs:master Aug 12, 2016
@vieiralucas vieiralucas deleted the patch-1 branch August 12, 2016 12:08
@guax
Copy link

guax commented Aug 12, 2016

馃懢

@keithamus
Copy link
Member

OMG I didn't even notice we have another contributor named Lucas! This is definitely a conspiracy.

@meeber
Copy link
Contributor

meeber commented Aug 12, 2016

@keithamus We need to remain vigilant at all times. The Lucas Syndicate has already announced their intentions for world domination per this comment. I think they perceive Chai as a stepping stone toward that end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants