Update getName to fix inspect in Firefox

[meeber]

This test started failing in Firefox after #789 was merged because Function.prototype.toString doesn't work on proxified functions per this article. I traced the specific error to this line, which was being called by Chai's inspect.

Replacing the logic in Chai's getName with @lucasfcosta's logic from getConstructorName in the check-error repository fixed the problem without breaking any tests.

Not sure it's worth it to pull that function into a separate module that's required by both Chai and check-error; seems like it might be overkill. An alternative would be for check-error to expose the function for Chai to require, but that doesn't quite feel right either. I'm okay with the duplicate logic across repos here, but if someone feels strongly otherwise I'm easily swayed.

[lucasfcosta]

I see no problem in duplicating it, this code is too small for us to separate it from the core. However if anyone wants to, I see no problem in doing that since there are many "micro modules" around (I think we all remember that left pad module).

Also, exposing that function on check-error feels wrong, since it has nothing to do with the functionality that module aims to provide.

This LGTM, but it would be nice to hear opinions from others just to make sure we all agree about that.

And, before I forget, good job @meeber 😄

[vieiralucas]

Even if this fires my OCD because of DRY reasons 😸
I agree with you guys that creating a module just for this is overkill.

LGTM

Nice one @meeber

EDIT:
I think it would be great to hear @keithamus opinion before merging

[keithamus]

LGTM. Let's ship it for now but I think its worth pulling into a new module one day. I, for one, welcome our micro module overlords.