Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit global actual #815

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Remove implicit global actual #815

merged 1 commit into from
Oct 2, 2016

Conversation

shvaikalesh
Copy link
Contributor

Would you like a PR with strict mode added?

vieiralucas
vieiralucas approved these changes Oct 2, 2016
View reviewed changes
Copy link
Member

@vieiralucas vieiralucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fire today! Nice catch!

@vieiralucas
Copy link
Member

This LGTM.

Regarding strict mode, I think you could read #578.

@meeber
Copy link
Contributor

meeber commented Oct 2, 2016 •
edited

LGTM!

There's a lot of discussion regarding strict mode in #578. Seems inevitable that it'll be added.

EDIT: JINX

EDIT: 1 2 3 4 5 6 7 8 9 10

EDIT: @vieiralucas Have fun NEVER TALKING AGAIN! :D

@vieiralucas vieiralucas merged commit 809ac3e into chaijs:master Oct 2, 2016
@shvaikalesh
Copy link
Contributor Author

Thanks for the link, interesting reading 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vieiralucas vieiralucas vieiralucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shvaikalesh @vieiralucas @meeber