Add .empty to assert interface #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
lucasfcosta
reviewed
Oct 5, 2016
| * | ||
| * @name isNotEmpty | ||
| * @alias notEmpty | ||
| * @param {Object|Array|String} target |
There was a problem hiding this comment.
Isn't it worth it to include Map and Set here? Just to keep things explicit, what do you guys think?
|
I just left a minor nitpicky comment about the accepted types of arguments for the method on the assert interface. If you think it's not needed feel free to merge. Despite that, LGTM! Awesome work @shvaikalesh! Thank you for this 😄 |
|
@lucasfcosta thanks for the review, fixed that. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #812.