Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implementation frames from stack trace #922

Merged
merged 5 commits into from
Apr 4, 2017
Merged

Remove implementation frames from stack trace #922

merged 5 commits into from
Apr 4, 2017

Commits on Mar 23, 2017

  1. feat: improve keep_ssfi flag 

    - Allows the `keep_ssfi` flag to be set when creating new Assertion
  objects by providing its value as the fourth argument.

- Updates the `transferFlags` util to only transfer `keep_ssfi` when the
  `includeAll` argument is set to `true`.

- Updates assertion creation and proxify utils to only set `ssfi` if
  `keep_ssfi` isn't set.

- Updates inline docs to reflect expanded usage of `keep_ssfi`.
    @meeber
    meeber committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    cf84f95 View commit details
    Browse the repository at this point in the history

  2. fix: remove frames from bdd interface stack 

    - Make it so that only `AssertionError` is thrown from inside of an
  assertion

- Always pass the current `ssfi` to a `new AssertionError` inside of an
  assertion

- Always pass the current `ssfi` to a new `Assertion` inside of an
  assertion, and set the `keep_ssfi` flag

- Improve the `globalErr` test helper function to also validate that
  the thrown error's stack trace doesn't contain implementation frames
    @meeber
    meeber committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    4b09010 View commit details
    Browse the repository at this point in the history

  3. fix: remove frames from assert interface stack 

    - Make it so that only `AssertionError` is thrown from inside of an
  assert interface wrapper function

- Always set `ssfi` to the current function when creating a new
  `AssertionError` inside of an assert interface wrapper function

- Always set `ssfi` to the current function when creating a new
  `Assertion` inside of an assert interface wrapper function,
  and set the `keep_ssfi` flag

- Improve the `globalErr` test helper function to also validate that the
  thrown error's stack trace doesn't contain frames from the assert
  interface
    @meeber
    meeber committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    b584b94 View commit details
    Browse the repository at this point in the history

  4. refactor: rename keep_ssfi to lockSsfi

    @meeber
    meeber committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    8fad9c8 View commit details
    Browse the repository at this point in the history

  5. docs: remove excessive comments from tests

    @meeber
    meeber committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    a253b4c View commit details
    Browse the repository at this point in the history