Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom message not always respected #934

Closed
wants to merge 1 commit into from

Conversation

artsoroka
Copy link

Inside "closeTo" function "this" already references an Assertion with "msg" parameter previously being set, so no need to call new Assertion

Fixes #923

@meeber
Copy link
Contributor

meeber commented Feb 15, 2017

Hi @artsoroka. Thanks for the PR. Although this solution does technically resolve the problem with .closeTo, it's not really compatible with #922, and would need to be refactored again as soon as #922 is merged. Therefore, the current plan is to wait until #922 is merged and then fix all the custom message issues in one go.

@meeber meeber closed this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom message not always respected
2 participants