Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure complex object keys are quoted #46

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jun 10, 2021

Fix #45

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #46 (5e2338d) into master (1664d70) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   74.22%   74.59%   +0.37%     
==========================================
  Files          19       19              
  Lines         609      618       +9     
==========================================
+ Hits          452      461       +9     
  Misses        157      157              
Impacted Files Coverage Δ
lib/helpers.js 99.15% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1664d70...5e2338d. Read the comment docs.

@keithamus keithamus merged commit 917757d into chaijs:master Jun 24, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pcorpet pcorpet deleted the complex-key branch June 25, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote complex keys in objects
2 participants