Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload bin directory to azure artifacts #6976

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Upload bin directory to azure artifacts #6976

merged 6 commits into from
Apr 30, 2024

Conversation

ShortDevelopment
Copy link
Contributor

@ShortDevelopment ShortDevelopment commented Apr 16, 2024 •
edited

Goals

  • Provide "nightly" builds for all platforms
  • Allow to debug per PR issues using the binaries from a CI-Run

Issues

  • macOS-builds created on CirrusCI are not included

Docs: Azure Pipeline Artifacts

ShortDevelopment
ShortDevelopment commented Apr 17, 2024
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
@ShortDevelopment ShortDevelopment marked this pull request as draft April 17, 2024 00:37
@ShortDevelopment ShortDevelopment marked this pull request as ready for review April 17, 2024 19:56
@ShortDevelopment
Copy link
Contributor Author

ShortDevelopment commented Apr 17, 2024 •
edited

@ppenzin Could you have a quick look at this?

@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 21, 2024

@ppenzin what do you think of this temporarily storing our CI builds?

It's not clear how long they kept for.

@ShortDevelopment
Copy link
Contributor Author

@rhuanjl This can be configured in the Azure DevOps settings
https://learn.microsoft.com/en-us/azure/devops/pipelines/policies/retention

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

JoseIvanHernandez
JoseIvanHernandez approved these changes Apr 26, 2024
View reviewed changes
Copy link

@JoseIvanHernandez JoseIvanHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

@ShortDevelopment
Copy link
Contributor Author

@JoseIvanHernandez Please stop the spam!
I've already reported you to GitHub!

@JoseIvanHernandez
Copy link

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 27, 2024 •
edited

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

When you comment on a pull request everyone tagged in it gets a notification.

I'm a little confused what you were trying to do here; a pull request (PR) is a request for the maintainers of a project to merge a contribution of some kind. This project is currently maintained by @ppenzin and I; it's up to us if/when a PR is merged.

This PR is a suggested developer experience feature from @ShortDevelopment, we're waiting until my fellow maintainer @ppenzin has a chance to consider it before deciding if to merge it.

If you have any other questions about this project (chakra core) or how to contribute to it feel free to either open an issue or join our discord server to chat (see the read me on the code page for a discord link).

ppenzin
ppenzin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@ppenzin ppenzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, I think Azure purges the storage periodically and shouldn't get overwhelmed, but we can adjust the frequency of publishing later.

@ShortDevelopment
Copy link
Contributor Author

I've done a lot of small commits
Just squash-merge the whole thing

@rhuanjl rhuanjl merged commit 5f53f55 into chakra-core:master Apr 30, 2024
24 checks passed
@ShortDevelopment ShortDevelopment deleted the feature/ci/azure-artifacts branch April 30, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenzin ppenzin ppenzin approved these changes

@JoseIvanHernandez JoseIvanHernandez JoseIvanHernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShortDevelopment @rhuanjl @JoseIvanHernandez @ppenzin