Skip to content

Commit

Permalink
Add explicit type declaration to ChakraProvider.defaultProps (#6464)
Browse files Browse the repository at this point in the history
* fix(chakra-provider): ensure typed declaration for `ChakraProvider.defaultProps`

* docs: update changesets

* refactor: move logic for default theme inside `ChakraProvider` component

* docs: revise changeset

* refactor: code

Co-authored-by: Segun Adebayo <joseshegs@gmail.com>
  • Loading branch information
rossng and segunadebayo committed Aug 13, 2022
1 parent 597966e commit b735aae
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/three-jokes-swim.md
@@ -0,0 +1,5 @@
---
"@chakra-ui/react": minor
---

Remove `ChakraProvider.defaultProps` and move logic inside the component.
9 changes: 3 additions & 6 deletions packages/react/src/chakra-provider.tsx
Expand Up @@ -2,7 +2,7 @@ import {
ChakraProvider as BaseChakraProvider,
ChakraProviderProps as BaseChakraProviderProps,
} from "@chakra-ui/provider"
import { theme } from "@chakra-ui/theme"
import { theme as defaultTheme } from "@chakra-ui/theme"
import { ToastProvider, ToastProviderProps } from "@chakra-ui/toast"

export interface ChakraProviderProps extends BaseChakraProviderProps {
Expand All @@ -14,17 +14,14 @@ export interface ChakraProviderProps extends BaseChakraProviderProps {

export function ChakraProvider({
children,
theme = defaultTheme,
toastOptions,
...restProps
}: ChakraProviderProps) {
return (
<BaseChakraProvider {...restProps}>
<BaseChakraProvider theme={theme} {...restProps}>
{children}
<ToastProvider {...toastOptions} />
</BaseChakraProvider>
)
}

ChakraProvider.defaultProps = {
theme,
}

1 comment on commit b735aae

@vercel
Copy link

@vercel vercel bot commented on b735aae Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.