fix(number-input): spinner getting stuck in useNumberInput button props #4703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4646
📝 Description
Using
useNumberInput
and setting amin
and/ormax
value and a chakra<Button />
withgetIncrementButtonProps
orgetDecrementButtonProps
the spinner gets stuck if you reach the limit and move the mouse off the now disabled button while still holding left click in latest Chromium-based browsers. In Firefox it's fine.🚀 New behavior
Adding an
onPointerLeave
event handler to the existing ones seems to fix the problem. This was also recommended in this React issue as a solution.The
onPointerUp
handler is also needed if the mouse doesn't leave the button while editing the input field value.💣 Is this a breaking change (Yes/No):
No