New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): resolve cannot import module #4818
fix(cli): resolve cannot import module #4818
Conversation
If tsconfig.json didn't have the settings for ts-node it ended up giving this error because it could only use CommonJS. Just override one of the user project settings to be able to use CommonJS.
🦋 Changeset detectedLatest commit: 4fabdf3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-storybook – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/DrcaG6gcdtjFG9tDgjGLchqauJtT chakra-ui – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/3pTQqEAA9MnbDU63P7xFP7puCEg3 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4fabdf3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @igorwessel 💖
The explanation and you proposed solution makes total sense. LGTM 🚀
Co-authored-by: Tim Kolberger <tim@kolberger.eu>
Co-authored-by: Tim Kolberger <tim@kolberger.eu>
I'm looking forward to this pr. |
Fix is upstream but not yet released See chakra-ui/chakra-ui#4818
* style(Tabs): update Tabs component style * fix: import textStyles from non-aliased path until upstream fix Fix is upstream but not yet released See chakra-ui/chakra-ui#4818 * fix: remove commented style prop * style: update line-light tab colors to fix a11y warnings * style(Tabs): update theme colors for light/dark line variants
Closes #4652
📝 Description
If tsconfig.json didn't have the settings for ts-node
it ended up giving this error because it could only use CommonJS.
Just override one of the user project settings to be able to use CommonJS.
⛳️ Current behavior (updates)
Fix cannot import module when user tsconfig use custom path aliases
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information