Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): resolve cannot import module #4818

Conversation

igorwessel
Copy link
Contributor

Closes #4652

📝 Description

If tsconfig.json didn't have the settings for ts-node
it ended up giving this error because it could only use CommonJS.
Just override one of the user project settings to be able to use CommonJS.

⛳️ Current behavior (updates)

Fix cannot import module when user tsconfig use custom path aliases

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

If tsconfig.json didn't have the settings for ts-node
it ended up giving this error because it could only use CommonJS.
Just override one of the user project settings to be able to use CommonJS.
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2021

🦋 Changeset detected

Latest commit: 4fabdf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chakra-ui/cli Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-storybook – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/DrcaG6gcdtjFG9tDgjGLchqauJtT
✅ Preview: https://chakra-ui-storybook-git-fork-igorwessel-fixcli-8f097d-chakra-ui.vercel.app

chakra-ui – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/3pTQqEAA9MnbDU63P7xFP7puCEg3
✅ Preview: https://chakra-ui-git-fork-igorwessel-fixcli-custom-pa-a22e3b-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4fabdf3:

Sandbox Source
create-react-app-ts Configuration

Copy link
Contributor

@TimKolberger TimKolberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @igorwessel 💖

The explanation and you proposed solution makes total sense. LGTM 🚀

.changeset/violet-frogs-sparkle.md Outdated Show resolved Hide resolved
.changeset/violet-frogs-sparkle.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Kolberger <tim@kolberger.eu>
Co-authored-by: Tim Kolberger <tim@kolberger.eu>
@kasim444
Copy link

I'm looking forward to this pr.

@segunadebayo segunadebayo merged commit 489731c into chakra-ui:main Oct 12, 2021
@github-actions github-actions bot mentioned this pull request Oct 12, 2021
@igorwessel igorwessel deleted the fix(cli)--custom-path-cannot-import-module branch October 12, 2021 11:07
karrui added a commit to opengovsg/FormSG that referenced this pull request Oct 13, 2021
karrui added a commit to opengovsg/FormSG that referenced this pull request Oct 21, 2021
* style(Tabs): update Tabs component style

* fix: import textStyles from non-aliased path until upstream fix

Fix is upstream but not yet released

See chakra-ui/chakra-ui#4818

* fix: remove commented style prop

* style: update line-light tab colors to fix a11y warnings

* style(Tabs): update theme colors for light/dark line variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chakra-cli doesn't find files referenced as custom paths in tsconfig.json
4 participants