Opening Collapse correctly through many clicks #7819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@henriquesml Was this already resolved elsewhere? It looks like this was intended to solve #7775. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As @fidalgodev reported in #7775, the Collapse transition does not work when you rapidly click multiple times.
@segunadebayo, why do we set the
displayproperty toblockornonedepending on thestartingHeight?.Another solution for this is to set unmountOnExit to true, but it doesn't seem right to me.
⛳️ Current behavior (updates)
The exit animation doesn't happen.
🚀 New behavior
The exit animation runs smoothly.
💣 Is this a breaking change (Yes/No):
Not sure.