You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to set a style-src CSP without unsafe-inline
⛳️ Current behavior (updates)
Chakra currently uses both the style attribute on HTML elements and an injected style element. Both require unsafe-inline style-src.
🚀 New behavior
Uses direct style props like flex={1} instead of style={{ flex: 1 }}.
Uses __css instead of style where an style object is used.
Adds the option to pass a nonce to the ColorModeProvider where the style element is injected.
💣 Is this a breaking change:
No
📝 Additional Information
I was unable to test the behaviour locally, because I had issues linking to the local directory from my package.json. I haven't tested all changes myself, so please take a good look.
Also, there are some places where a style attribute is set on motion.div. I was not sure how to handle this, so I haven't fixed those issues.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
it would be really nice to get this merged, even though I know y'all are working on the v3 migration in earnest. this would be really helpful for those of us who're going to be on v2 for a while
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8043, #7600
📝 Description
This PR allows to set a style-src CSP without unsafe-inline
⛳️ Current behavior (updates)
Chakra currently uses both the style attribute on HTML elements and an injected style element. Both require unsafe-inline style-src.
🚀 New behavior
flex={1}instead ofstyle={{ flex: 1 }}.__cssinstead ofstylewhere an style object is used.nonceto the ColorModeProvider where the style element is injected.💣 Is this a breaking change:
No
📝 Additional Information
I was unable to test the behaviour locally, because I had issues linking to the local directory from my package.json. I haven't tested all changes myself, so please take a good look.
Also, there are some places where a style attribute is set on
motion.div. I was not sure how to handle this, so I haven't fixed those issues.