Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlight): add case sensitive prop #8380

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

arusahni
Copy link

@arusahni arusahni commented Mar 22, 2024

📝 Description

The Highlight component currently uses a case-insensitive regex to perform matching. This adds a caseSensitive boolean property to the component (and underlying hook) to switch the behavior to case-sensitive matching.

🚀 New behavior

  • Add a caseSensitive property to the Highlight component to allow for case-sensitive highlighting.
  • Add a caseSensitive parameter to the useHighlight hook to allow for case-sensitive highlight group generation.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

This is my first Chakra PR -- please let me know if I've missed anything! I understand that the main branch is currently the in-progress v3. If this PR is accepted, I'll create another PR to port it forward into v3 for parity.

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 9803e41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@chakra-ui/react Minor
@chakra-ui/props-docs Minor
@chakra-ui/test-utils Patch
@chakra-ui/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Mar 22, 2024 7:21pm
chakra-ui-website ✅ Ready (Inspect) Visit Preview Mar 22, 2024 7:21pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant