Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Readme.md from bundle #618

Closed
wants to merge 2 commits into from

Conversation

H4ad
Copy link

@H4ad H4ad commented Nov 1, 2023

Closes #617

This will save ~631GB/week (3,7×228240517÷1024÷1024) of bandwidth (13.3kB to 10.4kB)

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #618 (a6b9c4f) into main (f7b29ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files           8        8           
  Lines         517      517           
=======================================
  Hits          515      515           
  Misses          2        2           

@H4ad
Copy link
Author

H4ad commented Nov 1, 2023

I think we should not remove it, but instead replace it with a cheaper version, removing it will probably make the page on NPM be empty.

@sindresorhus
Copy link
Member

#617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove README.md from bundle
2 participants