Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .replit file #622

Merged
merged 1 commit into from Jan 6, 2024
Merged

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Jan 6, 2024

As noted in #587, the Replit demo no longer works anymore. f7b29ae partially fixes this, but the .replit file still remains. Even importing the GitHub project manually results in an error:

image

When the original PR was made, iirc dependencies were installed automatically. There are other things to note, too. In the .replit file, there is a similar deployments.run property which has similar functionality. As mentioned in the original issue, using replit to run the example now requires an account. I think these issues, along with the removal of the badge, suggests that the .replit file should be removed. Besides, there are better alternatives, like RunKit, or StackBlitz as mentioned previously.

@hyperupcall hyperupcall changed the title Remove .replit file Remove .replit file Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7b29ae) 99.61% compared to head (5d028d7) 99.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files           8        8           
  Lines         517      517           
=======================================
  Hits          515      515           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qix-
Copy link
Member

Qix- commented Jan 6, 2024

Thanks, yeah I think this was missed.

Cheers!

@Qix- Qix- merged commit 2db3c77 into chalk:main Jan 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants