Skip to content

Commit

Permalink
Fix linting issues after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
JakeGinnivan committed Sep 29, 2022
1 parent 2f158d5 commit 3e9f3b9
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 17 deletions.
2 changes: 1 addition & 1 deletion packages/apply-release-plan/src/index.test.ts
Expand Up @@ -3,7 +3,7 @@ import {
ReleasePlan,
Config,
NewChangeset,
ComprehensiveRelease
ComprehensiveRelease,
} from "@changesets/types";
import * as git from "@changesets/git";
import fs from "fs-extra";
Expand Down
Expand Up @@ -40,7 +40,7 @@ describe("publishPackages", () => {
await publishPackages({
packages: (await getPackages(cwd)).packages,
access: "public",
preState: undefined
preState: undefined,
});
expect(npmUtils.getTokenIsRequired).not.toHaveBeenCalled();
});
Expand Down
Expand Up @@ -24,7 +24,7 @@ git.tag.mockImplementation(() => Promise.resolve(true));
publishPackages.mockImplementation(() =>
Promise.resolve([
{ name: "pkg-a", newVersion: "1.1.0", published: true },
{ name: "pkg-b", newVersion: "1.0.1", published: true }
{ name: "pkg-b", newVersion: "1.0.1", published: true },
])
);

Expand Down
Expand Up @@ -8,7 +8,7 @@ export async function getUntaggedPrivatePackages(
tool: Tool
) {
const packageWithTags = await Promise.all(
privatePackages.map(async privatePkg => {
privatePackages.map(async (privatePkg) => {
const tagName =
tool === "root"
? `v${privatePkg.packageJson.version}`
Expand All @@ -29,7 +29,7 @@ export async function getUntaggedPrivatePackages(
untagged.push({
name: packageWithTag.pkg.packageJson.name,
newVersion: packageWithTag.pkg.packageJson.version,
published: false
published: false,
});
}
}
Expand Down
10 changes: 6 additions & 4 deletions packages/cli/src/commands/publish/index.ts
Expand Up @@ -66,10 +66,10 @@ export default async function run(
access: config.access,
otp,
preState,
tag: releaseTag
tag: releaseTag,
});
const privatePackages = packages.filter(
pkg => pkg.packageJson.private && pkg.packageJson.version
(pkg) => pkg.packageJson.private && pkg.packageJson.version
);
const untaggedPrivatePackageReleases = tagPrivatePackages
? await getUntaggedPrivatePackages(privatePackages, cwd, tool)
Expand All @@ -82,8 +82,10 @@ export default async function run(
warn("No unpublished projects to publish");
}

const successfulNpmPublishes = publishedPackages.filter(p => p.published);
const unsuccessfulNpmPublishes = publishedPackages.filter(p => !p.published);
const successfulNpmPublishes = publishedPackages.filter((p) => p.published);
const unsuccessfulNpmPublishes = publishedPackages.filter(
(p) => !p.published
);

if (successfulNpmPublishes.length > 0) {
success("packages published successfully:");
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/commands/publish/publishPackages.ts
Expand Up @@ -78,7 +78,7 @@ export default async function publishPackages({
access,
otp,
preState,
tag
tag,
}: {
packages: Package[];
access: AccessType;
Expand All @@ -99,7 +99,7 @@ export default async function publishPackages({

const twoFactorState: TwoFactorState = getTwoFactorState({
otp,
publicPackages
publicPackages,
});

return Promise.all(
Expand Down
2 changes: 1 addition & 1 deletion packages/config/src/index.test.ts
Expand Up @@ -47,7 +47,7 @@ test("read reads the config", async () => {
bumpVersionsWithWorkspaceProtocolOnly: false,
privatePackages: {
tag: false,
version: true
version: true,
},
___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH: {
onlyUpdatePeerDependentsWhenOutOfRange: false,
Expand Down
6 changes: 3 additions & 3 deletions packages/config/src/index.ts
Expand Up @@ -9,7 +9,7 @@ import {
WrittenConfig,
Fixed,
Linked,
PackageGroup
PackageGroup,
} from "@changesets/types";
import packageJson from "../package.json";
import { getDependentsGraph } from "@changesets/get-dependents-graph";
Expand Down Expand Up @@ -467,9 +467,9 @@ export let parse = (json: WrittenConfig, packages: Packages): Config => {
privatePackages: json.privatePackages
? {
version: json.privatePackages.version ?? true,
tag: json.privatePackages.tag ?? false
tag: json.privatePackages.tag ?? false,
}
: { version: true, tag: false }
: { version: true, tag: false },
};

return config;
Expand Down
2 changes: 1 addition & 1 deletion packages/git/src/index.test.ts
Expand Up @@ -13,7 +13,7 @@ import {
getChangedPackagesSinceRef,
getChangedChangesetFilesSinceRef,
getAllTags,
tagExists
tagExists,
} from "./";

const f = fixtures(__dirname);
Expand Down
2 changes: 1 addition & 1 deletion packages/git/src/index.ts
Expand Up @@ -304,7 +304,7 @@ export async function remoteTagExists(tagStr: string) {
"--tags",
"origin",
"-l",
tagStr
tagStr,
]);
const output = gitCmd.stdout.toString().trim();
const tagExists = !!output;
Expand Down

0 comments on commit 3e9f3b9

Please sign in to comment.