Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid version changing for release type "none" #1324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AkatQuas
Copy link

@AkatQuas AkatQuas commented Mar 12, 2024

Before, it would assemble unnecessary version change for packages, output example:

{
  changesets: [
    {
      releases: [Array],
      summary: 'composite',
      id: 'feat+image-new_2024-03-05'
    }
  ],
  releases: [
    {
      name: '@scopeA/image-filter',
      type: 'patch',
      oldVersion: '13.0.0',
      changesets: [Array],
      newVersion: '13.0.1'
    },
    {
      name: '@scopeB/app1',
      type: 'none',
      oldVersion: '1.0.0',
      changesets: [],
      newVersion: '1.0.0'
    },
    {
      name: '@scopeB/app2',
      type: 'none',
      oldVersion: '1.0.0',
      changesets: [],
      newVersion: '1.0.0'
    },
  ],
  preState: undefined
}

It would touch package.json in @scopeB/app1 and @scopeB/app2 with unnecessary IO event.

This Pull Request would skip such issue totally.

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 9850d8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@AkatQuas
Copy link
Author

Would you please review this at your convenience ? @Andarist . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant